Brave-browser: XHR requests canceled across a wide range of websites

[Swader]

Full discussion in Twitter here: https://twitter.com/bitfalls/status/1082896409299505152

---

Version 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Win10 x64.

• Does not happen on OS X.
• Does not happen in private browsing mode.
• All extensions were OFF for the duration of reproducing the problems (I have only 3 extensions total - metamask, json viewer and Workona).
• Shields are completely off during all these tests.

---

On certain websites, ajax requests get canceled for no apparent reason (code -3, ERR_ABORT).

Examples are: https://www.diffbot.com/careers and https://gitcoin.co/explorer?network=mainnet&keywords=nimbus&order_by=-web3_created

Here is a HAR reproduction for Diffbot: https://gist.github.com/Swader/a994365480ee63927eb4045163133f89

Example screenshot:

[srirambv]

This looks fixed on the new beta. Could have been the CORS issue which wasn't fixed in 0.59.20.

@Swader mind checking it on the new beta that went out yesterday?

[Swader]

Still happens, same conditions. All extensions and shields off. I recommend adding a debug output and a command line --debug flag to the executable before every ERR_ABORT emit so that we can find out when these canels are being triggered.

[srirambv]

Just to confirm you are still seeing this on 0.59.21 right?

[Swader]

Correct: Version 0.59.21 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)

[srirambv]

@btlechowski @GeetaSarvadnya could you guys give it a try on Windows?

cc: @iefremov @simonhong

[iefremov]

I don't think its the CORS issue, looks like smth different.
Maybe check this behavior in Chrome?

[srirambv]

I can't reproduce the issue on Linux with the same build.

[Swader]

It works in latest Chrome and Opera.
It does not happen on any other OS, or even in private mode on Win+Brave.

[iefremov]

Thanks for checking this. Probably it is also worth checking in Chrome version corresponding to the problematic Brave build (Chromium: 72.0.3626.28) @srirambv

[Swader]

Another example: https://prvikvadrat.hr/

[Swader]

Another example on Github. A few refreshes with cache off helped.

[cndouglas]

+1 from me (#2930).

• Happens on the current beta (0.59.x) and dev (0.60.x) releases, but not the current public release (0.58.x).
• Happens on macOS (10.14)
• Seems to happen with a fresh profile after restarting the browser at least once
• Turning off shields does not help
• More examples of websites:
  
  
  
  • https://github.com while logged in (Recent Activity section does not load)
  
  
  • https://hstspreload.org/?domain=brave.com (HSTS check does not finish loading)
  
  
  • https://brave.com/jobs/ (job listings do not load)
  
  

[bbondy]

this seems serious and new based on ^, putting P1 and putting as release/blocking.

[bsclifton]

@Liunkae can you please update to latest? I'm curious if recent fixes resolve this problem for you (works for me!™)

For what it's worth, I'm on DEV channel (0.60.12)

[iefremov]

Can't reproduce on Dev/Beta on MacOS.

Anyone with a stable repro, please save a netlog. To do this:

1. Open brave://net-export/
2. Click "Start logging to disk"
3. Reproduce the bug in some other tab
4. Return to brave://net-export, click "Stop logging", attach the resulted file to this ticket :)

Thanks

[Swader]

Here's an older export from me.
chrome-net-export-log.zip

[cndouglas]

Here's a netlog: chrome-net-export-log.json.zip

Still reproduces (100% of the time) for me with the following:

Brave | 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision | 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS | Mac OS X
macOS version 10.14.2

Steps to reproduce:

1. Start with a fresh profile.
2. Quit the browser.
3. Start Brave again.
4. Go to https://brave.com/jobs
5. Notice that the job listings do not load, even with shields off:

The developer console shows that one of the resources was canceled:

[bbondy]

We tracked it down to some code for the DOM distiller. Working on a fix.

[kjozwiak]

Removed OS/Windows as this is affecting macOS as well.

[srirambv]

Verification passed on

Brave | 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
-- | --
Revision | 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS | Linux

• Verified steps from original issue
• Verified steps from https://github.com/brave/brave-browser/issues/2901#issuecomment-454535749

Verification passed on

Brave | 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
-- | --
Revision | 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS | Windows 10

• Verified steps from original issue
  
  
  
  • Verified steps from https://github.com/brave/brave-browser/issues/2901#issuecomment-454535749
  
  

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave | 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
-- | --
Revision | eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS | Mac OS X

• Verified steps from https://github.com/brave/brave-browser/issues/2901#issue-398001488
• Verified steps from https://github.com/brave/brave-browser/issues/2901#issuecomment-453586667
• Verified steps from https://github.com/brave/brave-browser/issues/2901#issuecomment-454121739
• Verified steps from https://github.com/brave/brave-browser/issues/2901#issuecomment-454535749

[Swader]

Please update issue to ping us when this lands in beta on Win

[bbondy]

It's already updated on dev and beta

[Swader]

Indeed it seems to work now. Can you explain how, without an update process?

[srirambv]

@Swader your app should have been updated to 0.59.25. Could you check brave://version?

[Swader]

It did indeed, but I don't remember the update process having happened. Might have occurred between a PC restart. Anyway thanks looks good now!