Brave-browser: Broken image in rewards panel

[btlechowski]

Steps to Reproduce

1. Clean install
2. Enable rewards through rewards panel

Actual result:

• Token grant image is broken
• ~weird text: MISSING: noActivity~
• ~rewards height is too big~
  

Expected result:

Rewards panel in Beta 0.57.7

Reproduces how often:

always

Brave version (brave://version info)

Brave | 0.58.10 Chromium: 71.0.3578.53 (Official Build) dev (32-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Windows 7

Reproduced on MacOS, Brave 0.58.10 by @LaurenWags

Reproducible on current release:

Does not reproduce on Release(0.56.15) nor Beta(0.57.7) Channels

Not reproducible on

Brave | 0.58.9 Chromium: 71.0.3578.53 (Official Build) dev (64-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Windows

This is a recent regression

cc @kjozwiak @srirambv @GeetaSarvadnya @NejcZdovc @ryanml @emerick

[ryanml]

@btlechowski the first two problem (missing image and string) will for sure be fixed.

As for the new panel height, this was a design update made by @jenn-rhim in myself so there is not a flickering of height as you move between the panel and summary.

[kjozwiak]

@btlechowski the first two problem (missing image and string) will for sure be fixed.

Thanks @ryanml, can we get this fixed in dev before 0.58.x moves into BETA next week? Couldn't reproduce with the latest beta so definitely a new regression:

Brave | 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Mac OS X

[ryanml]

@kjozwiak - definitely, I should be able to have this out EOD actually.

[petemill]

This is two separate issues, we should split them up

[petemill]

Issue for missing string - https://github.com/brave/brave-browser/issues/2261

[LaurenWags]

@ryanml @jenn-rhim re: https://github.com/brave/brave-browser/issues/2259#issuecomment-442233715 and panel height, this is what you see when on a site. it looks odd to have the white space at the bottom. can this be adjusted?

[ryanml]

@laurenwags this will be fixed with: https://github.com/brave/brave-core/pull/957

[LaurenWags]

awesome, thanks @ryanml 😄

[LaurenWags]

Verified passed with

Brave | 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
-- | --
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Mac OS X

Verification Passed on

Brave | 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
-- | --
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Windows

Verification PASSED using Ubuntu 18.0.4 x64 with the following build:

Brave | 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
--- | ---
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Linux