Brave-browser: Rewards- Able to tip Sites/Twitch/YT publishers even when `Brave Rewards` is disabled

Created on 22 Nov 2018  路  4Comments  路  Source: brave/brave-browser

Description

When Brave Rewards is disabled we can still tip sites, YT and Twitch publishers, we won't see anything displayed under Summary and Tip section until we enable Rewards.
After enabling Rewards we can see tipping amount is redeemed from wallet and also we can see tipped sites displayed under Tip section.

Steps to Reproduce

  1. Launch Brave with clean profile 0.58.9
  2. Enable rewards through welcome screen or Brave Rewards panel
  3. Disable the Brave Rewards switch
  4. Import brave wallet ( Make sure imported wallet balance is dispalyed on wallet)
  5. Tip sites including YT and Twitch
  6. Observe that wallet amount redeemed for tipped sites

Actual result:

Able to tip sites even when Brave Rewards is disabled

brave rewards- disabled- tip sites

Expected result:

When Brave Rewards is disabled, user should not be able to tip sites/YT/Twitch publishers.

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.58.9 Chromium: 71.0.3578.53聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Windows

Reproducible on current release: Yes

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@kjozwiak @LaurenWags @srirambv @btlechowski

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes bug featurrewards prioritP3 release-noteinclude

Most helpful comment

To note, the above comment will be addressed in this PR ^ https://github.com/brave/brave-core/pull/1282 , not https://github.com/brave/brave-core/pull/1034 cc: @LaurenWags

All 4 comments

@bradleyrichter @jenn-rhim - what is the expected behavior for the panel when Rewards is disabled?

Should it show the opt-in panel? if that's the case, we may need to adjust button text as we don't need to recreate the wallet at that point, just re-enable rewards.

When verifying this issue and the associated PR (https://github.com/brave/brave-core/pull/1034), we should also check this case:

  • Enable Rewards
  • If not automatically enabled, enable Ads.
  • Verify you see some Ads after some time browsing
  • Turn off Rewards (do not explicitly turn off Ads)
  • Verify after some time of browsing you do not see any Ads.

To note, the above comment will be addressed in this PR ^ https://github.com/brave/brave-core/pull/1282 , not https://github.com/brave/brave-core/pull/1034 cc: @LaurenWags

Verified passed with

Brave | 0.60.26 Chromium: 72.0.3626.96聽(Official Build)聽beta(64-bit)
-- | --
Revision | 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS | Mac OS X

  • Verified STR from description. Attempted to tip verified and unverified websites, verified and unverified YT channels, verified and unverified Twitch channels.
  • Verified this is what was displayed when the panel was clicked on
    screen shot 2019-02-12 at 5 37 31 pm

Verification passed on

Brave | 0.60.26 Chromium: 72.0.3626.96聽(Official Build)聽beta(64-bit)
-- | --
Revision | 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS | Linux

image

Verification passed on

Brave | 0.60.28 Chromium: 72.0.3626.96聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS | Windows 10

  • Verified STR from description.

image

Was this page helpful?
0 / 5 - 0 ratings