Brave-browser: Console logs error when sync is enabled

[srirambv]

Description

Console logs error when sync is enabled

Steps to Reproduce

1. Enable sync using --enable-brave-sync
2. Open brave://bravesync and open dev tools (F12)
3. Create a sync chain by entering a device name
4. Console logs error
5. Same errors while joining a sync chain as well

Actual result:

~https://youtu.be/189rrSZTGAY~
Edit: Updated link https://youtu.be/b4i3GL27tk0

Expected result:

Should not log any errors

Reproduces how often:

Easy

Brave version (brave://version info)

Brave | 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
-- | --
Revision | c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS | Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes on beta build

  Website problems only:

• Does the issue resolve itself when disabling Brave Shields?

• Is the issue reproducible on the latest version of Chrome?

Additional Information

Reproduced on Windows when joining to a sync chain created on Linux
cc: @darkdh @AlexeyBarabash @brave/legacy_qa

[srirambv]

These errors are logged everytime a button is clicked or switch is toggled on the sync page.

[kjozwiak]

@srirambv can you post the errors into a code insert or maybe post a screenshot? The YT video that was uploaded doesn't seem to be working. I get the following error whenever I attempt to view it:

Video unavailable
This video has been removed by the user

[srirambv]

Not sure how the video got removed. I'll reupload the video. Here's the console log

load_time_data.js:217 Unexpected condition on chrome://bravesync/: Could not find value for remove
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: [undefined] (remove) is not a string
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: Could not find value for remove
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: [undefined] (remove) is not a string
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: Could not find value for remove
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: [undefined] (remove) is not a string
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: Could not find value for remove
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: [undefined] (remove) is not a string
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: Could not find value for remove
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: [undefined] (remove) is not a string
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: Could not find value for remove
expect @ load_time_data.js:217
load_time_data.js:217 Unexpected condition on chrome://bravesync/: [undefined] (remove) is not a string

[LaurenWags]

Verified passed with

Brave | 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Mac OS X

• Verified using STR from description

Verification passed on

Brave | 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Windows

• Verified the STR, there is no console logs error.

Verification passed on

Brave | 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
-- | --
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Linux

[srirambv]

Removed QA pass label. Need to verify it against beta again

[GeetaSarvadnya]

Verification Passed on

Brave | 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
-- | --
Revision | 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS | Windows

• Verified the STR, now there are no console error logs (After initiating the sync and while joining sync with other device)

Verification passed on

Brave | 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
-- | --
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Linux

Verified passed with

Brave | 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
-- | --
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Mac OS X

• Verified STR in description for both new and existing sync chains