Brave-browser: Replace new tab pages for Private Windows with and without Tor

[tomlowenthal]

Test plan

Verify the screens roughly match the mock-ups (below)

• Private window
• Tor window

@tomlowenthal can help with verifying text

Description

In which @rossmoody is making the designs, @tomlowenthal is writing the text, with @riastradh-brave to implement.

[bbondy]

Is there a mockup of what this task is that we can put in here?
Only a couple working days left until the freeze, thanks!

[rossmoody]

These are the latest designs for this initiative. They are good to go.

[bbondy]

I suspect we need @cezaraugusto's help here if we're to make this task in time (he might already be working on it, not sure).

[bbondy]

Fairly sure this isn't making it in by the freeze tomorrow morning, so moving to the 1.0 project.

[bbondy]

Didn't realize there was activity in this, no problem moving back if we make the cut.

[rossmoody]

I think this is still on track to make it. @cezaraugusto has a better handle on status but we're on it and progress seems positive.

[tomlowenthal]

QA: note the following changes from the designs in this issue:

• Final text is in this doc, not the mockups
• Learn more overlay has been replaced with links to the knowledge base
• For this revision, all browsers get the DDG version, there's no impl of the DDG-free one

[srirambv]

Verification Passed on

Brave | 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
-- | --
Revision | 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS | Linux

• All support links to correct article on KB
• Tor window More info is missing which is mentioned in the document but not implemented. cc: @tomlowenthal to confirm if this needs to be tracked in a new issue?

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave | 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
-- | --
Revision | 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS | Mac OS X

• Verified that all the support links under Private windows are loading the correct tabs
• Noticed that the screen becomes white for a few seconds when initially loading brave://newtab, created https://github.com/brave/brave-browser/issues/1645
• Support links are not being loaded inline under Tor windows, created https://github.com/brave/brave-browser/issues/1647
• ensured that the text matched https://docs.google.com/document/d/1-LvUwonWwXiFJvw1MjLt9fsCWktEiKiEM7cZ-UN6uPQ
• ensured both Guest & Private windows are loading the new brave://newtab
• ensured that Tor windows are loading the new brave://newtab

Verification Passed on

Brave | 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
-- | --
Revision | 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS | Windows

• All support links to correct article on KB
• Support links are not being loaded inline under Tor windows, @kjozwiak has created issue 1647

[kjozwiak]

Tor window More info is missing which is mentioned in the document but not implemented. cc: @tomlowenthal to confirm if this needs to be tracked in a new issue?

@tomlowenthal as @srirambv mentioned above, the mockup from https://github.com/brave/brave-browser/issues/1507#issuecomment-429212976 doesn't display the Learn more under the THIS IS A Private Window with Tor section but the https://docs.google.com/document/d/1-LvUwonWwXiFJvw1MjLt9fsCWktEiKiEM7cZ-UN6uPQ document mentions that there should be a [Learn more] underneath. Let us know which one is correct and we'll create a new issue if Learn more should have been there.

[tomlowenthal]

Nice catch on the learn more. Let's open a new issue to re-add that link for 56; I don't think it should block the 55 release since right now it's redundant with the text below. And there may be some other design tweaks for 56, so we can roll that right in.

[rossmoody]

Yeah that was an intentional omission I made on the fly cause the screens were needed so quickly. Too many big learn more buttons all over the page and in Windows with Tor it would have made it two big purple buttons going to the same article.. The Private Window learn more button was adjusted to a link inline with the copy as well instead of a big button (we could probably follow suit in Tor windows but I'd like to sit with it for a bit).

[srirambv]

Logged follow up issue https://github.com/brave/brave-browser/issues/1667