Brave-browser: Use brave download link and brave link from "brave://flags" for stable/beta release

Created on 4 Oct 2018  路  15Comments  路  Source: brave/brave-browser

Description

Dev channel link under "Chrome://flags" is redirecting to chrome download page. Dev channel link needs to removed from the chrome flags page.

Steps to Reproduce

  1. Open Brave beta
  2. Navigate to "Chrome://flags"
  3. Click on "dev channel" link

Actual result:

dev channel link is redirecting to "Download Chrome for Windows" page.

Expected result:

Our dev channel link should be used from the brave://flags page for beta channel
and our beta channel link should be used from the brave://flags page for stable channel.

Reproduces how often:

Always

Brave version (chrome://version info)

Brave | 0.55.10 Chromium: 70.0.3538.22聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS | Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? NA
  • Does it reproduce on browser-laptop? NA

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

cc @bbondy

ODesktop OWindows OmacOS QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes about-pagerebrand bug prioritP3 release-noteexclude
Source
picture GeetaSarvadnya

All 15 comments

Nice catch @GeetaSarvadnya 馃憤BTW, this is only reproducible on the 0.55.x and not 0.56.x.

  • 0.56.2 Chromium: 70.0.3538.35 - not reproducible/link seems to be removed from the top
  • 0.55.11 Chromium: 70.0.3538.35 - Reproducible
kjozwiak picture kjozwiak on 5 Oct 2018

Quick example of the issue @GeetaSarvadnya mentioned above:

screen shot 2018-12-18 at 2 29 25 pm

Used the following build:

Brave | 0.58.14 Chromium: 71.0.3578.98聽(Official Build)聽(64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Mac OS X

kjozwiak picture kjozwiak on 18 Dec 2018

Still an issue. Came here after noticing it myself.

jonathansampson picture jonathansampson on 30 Jan 2019

This is still showing on release channel: 0.61.51 Chromium: 73.0.3683.75
Interested in cool new Chrome features? Try our beta channel.

and beta channel: 0.62.25 Chromium: 73.0.3683.67
Interested in cool new Chrome features? Try our dev channel

rebron picture rebron on 13 Mar 2019

We can just hide the whole line for all channels but especially for release channel.
If we do keep in beta channel link should be: https://brave.com/download-beta/
and for dev channel should be: https://brave.com/download-dev/

Although dev channel doesn't have the text at all.

rebron picture rebron on 13 Mar 2019

This is also an issue in the following:

Brave | 1.7.98 Chromium: 81.0.4044.113聽(Official Build)聽(64-bit)
-- | --
Revision | e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS | Windows聽10 OS Version 2004 (Build 19569.1000)

VelocityDesign picture VelocityDesign on 26 Apr 2020

We can just hide the whole line for all channels but especially for release channel.
If we do keep in beta channel link should be: https://brave.com/download-beta/
and for dev channel should be: https://brave.com/download-dev/

Although dev channel doesn't have the text at all.

I agree. Instead of removing it, we should just point it to the brave website.

VelocityDesign picture VelocityDesign on 26 Apr 2020

Re-opening after revert was done with https://github.com/brave/brave-core/pull/5521
cc: @simonhong

bsclifton picture bsclifton on 12 May 2020

edit: description and test plan changed and the issue is not applicable to Linux.

btlechowski picture btlechowski on 26 May 2020

@btlechowski This issue is not for linux. Originally, flags page in linux doesn't have dev channel link in beta release and beta channel link in stable release. Only mac/windows has channel link.
So, fixes for this issue don't make any difference for linux.

#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
  version_info::Channel channel = chrome::GetChannel();
  results.SetBoolean(
      flags_ui::kShowBetaChannelPromotion,
      channel == version_info::Channel::STABLE && !deprecated_features_only_);
  results.SetBoolean(
      flags_ui::kShowDevChannelPromotion,
      channel == version_info::Channel::BETA && !deprecated_features_only_);
#else
  results.SetBoolean(flags_ui::kShowBetaChannelPromotion, false);
  results.SetBoolean(flags_ui::kShowDevChannelPromotion, false);
#endif
simonhong picture simonhong on 26 May 2020
👍1

Verification passed on

Brave | 1.10.71 Chromium: 81.0.4044.138聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)
  • Reproduce the issue in 1.9.x, click on beta channel in chrome://flags is redirecting to download chrome page
  • Verified the STR from the description
  • Verified that dev channel link is not shown in chrome://flags page
    image
GeetaSarvadnya picture GeetaSarvadnya on 26 May 2020

@GeetaSarvadnya My PR that resolves this issues is https://github.com/brave/brave-core/pull/4601.
That PR replaced chrome branding and chrome link with brave branding and brave link instead of removing chrome link. This issue should be updated.

And, chrome link was only visible by stable and beta release.
In stable release, Interested in cool new Brave features? Try our beta channel. will be used.
In beta release, Interested in cool new Brave features? Try our dev channel..
And other channel (dev/nightly) don't have this link.

simonhong picture simonhong on 26 May 2020
👍1

Description and issue title are updated. Sorry for late update.
Forgot to update when I work on this issue :)

simonhong picture simonhong on 26 May 2020
😄1

Deleted QA Pass-Win64 as based on https://github.com/brave/brave-browser/issues/1422#issuecomment-633948229 this issue needs to be tested on Beta and Release channels.

btlechowski picture btlechowski on 26 May 2020
👍1

Verification passed using:

Nightly:

Brave | 1.11.28 Chromium: 81.0.4044.138聽(Official Build)聽nightly聽(64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Dev:

Brave | 1.10.74 Chromium: 81.0.4044.138聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Beta:

Brave | 1.10.73 Chromium: 81.0.4044.138聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

However, link is pointing to https://brave.com/download-beta/ but I'm already using Beta. We should perhaps use another link for this - either Dev (as the link text says) or Nightly. Logged follow up issue for this: https://github.com/brave/brave-browser/issues/9968

Release:

Brave | 1.10.86 Chromium: 83.0.4103.61聽(Official Build)聽(64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Beta

Brave | 1.10.85 Chromium: 81.0.4044.138聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)

Release


Brave | 1.10.86 Chromium: 83.0.4103.61聽(Official Build)聽(64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)
LaurenWags picture LaurenWags on 27 May 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

simonhong picture simonhong  路  3Comments
bsclifton picture bsclifton  路  3Comments
Sondro picture Sondro  路  3Comments
bsclifton picture bsclifton  路  3Comments
kerry-perret picture kerry-perret  路  3Comments