Brave-browser: Update puzzle icon for autoplay to an autoplay specific icon

[rebron]

Description

Currently using puzzle icon with red x mark. Need an autoplay specific icon.

Related

https://github.com/brave/brave-browser/issues/699

Test plan

Visit https://tesla.com/model3
Autoplay blocked icon should look like:

[rossmoody]

How do we feel about adjusting the scope of this to updating permissions icons for default and blocked states?

I think these icons also live in site settings page though i'm unsure if they are all pulling from the same place.

[rebron]

looks like different icons on chrome://settings/content

[rossmoody]

yeah, i think those are generated by iron icons which pulls from a different place than the omnibox, so we should prob break those changes out into another issue, some of them might get or be partially resolved with clifton's settings updates

[petemill]

This issue seems to now have a broad scope for all ombnibox permission icons, but https://github.com/brave/brave-core/pull/548 is only addressing autoplay and the generic extension icon, right @rossmoody ?

[rossmoody]

@rebron @petemill yeah that was an ill conceived suggestion. I do think replacing that lineup is important but there is additional consideration, sizes, and places that a change like that needs to take into account. should open up a separate issue, i adjusted the scope of this back to the original

[srirambv]

Verification Passed on

Brave | 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
-- | --
Revision | cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS | Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave | 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
-- | --
Revision | cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS | Mac OS X

Verification Passed on

Brave | 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
-- | --
Revision | cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS | Windows

[kjozwiak]

@rossmoody quick question regarding our current icon set while using the dark theme. Is there plans to incorporate a white set of icons for the dark theme? They're pretty hard to see with the current set when using the dark theme.. Example:

[rossmoody]

I agree, Bookmark icons as well. Would like to switch the shield alert circle to purple in dark theme instances as well. There is a huge list of UI adjustments on the docket but shields/rewards are consuming all atm.

[kjozwiak]

@rossmoody sounds good! Appreciate the update. Guessing there's no need to create issues. Sounds like it's on the list of things to do 👍