Brave-browser: Mac update relaunch doesn't launch new version of Brave

[RyanJarv]

Description

When updating from 0.54.4 to 0.55.1 clicking relaunch after the install closes the current window but doesn't launch the new version.

Steps to Reproduce

1. Install 0.54.4
2. Navigate to chrome://chrome
3. Click relaunch after update is done downloading/installing

Actual result:

Browser is closed and we don't see the new version open.

Brave can be launched again manually and will be on the right version though.

Expected result:

Clicking relaunch open's the updated version.

Reproduces how often:

Always

Brave version (about:brave info)

0.54.4 -> 0.55.1

Reproducible on current release:

Yes

Seeing this in Console around the time of the update:

error taskgated-helper com.brave.Browser.dev: Unsatisfied entitlements: com.apple.application-identifier

[petemill]

Same happened with 0.55.1 -> 0.55.2 for @bsclifton and me

[w0ts0n]

Just wanted to note, it did work for me. Also on MacOS.

[aekeus]

Did not work for me 0.55.1 -> 0.55.2 (macOS)

[bbondy]

Did not work for me 0.55.1 -> 0.55.2 (macOS)

[bsclifton]

Didn't for for me again ☹️ 0.55.2 => 0.55.3

[bsclifton]

With this last update (0.55.3 => 0.55.4), it looks like it tried to relaunch? but then quit really quick (the icon blipped). Had to manually relaunch 🙀

[yrliou]

Did not work for me 0.55.4 -> 0.55.5 (macOS)

[ltilve]

I was also able to still reproduce the issue when updating from the latest version.

Something that seems it could be related with the issue, is an error message related with the signing of the package that we had been able to see when starting the browser from the command line:

[ltilve]

I have been using directly the call to chrome://restart after installing the Mac package, which is always properly relaunching the browser when triggered before updating, and also after the updated version was started afterwards; but which has the very same issue if it's manually triggered at the moment the update download is completed.

So the issue is apparently not coming from anything specific of the relaunch action on the settings/help or any restart, but just when the bundle has changed.

[bbondy]

The task involves some devops work for @mbacchi and we won't be able to get to it in time for 0.55.x So moving it as a priority/p2 in 1.x for asap attention when we get past this release. We'll uplift it into the next milestone or a hotfix.

[kjozwiak]

@bbondy @rebron @bsclifton we should really get this fixed. Every time we release an update, we have some complaints from the community and internally. Users who don't know this issue exists usually think that thier update failed. Added this into the General so we can discuss during our triage meetings.

[w0ts0n]

We implemented/setup a new omaha system to fix the slow downloads issue. Once we are done testing and are sure it's fixed, we can run an update on the staging sparkle/omaha which may fix this issue. We should wait on Simon to get back from PTO too.

We know this has to be fixed, but I'm not calling this urgent. it's an annoying bug, but not a blocker.

[bridiver]

I saw (com.apple.xpc.launchd.oneshot.0x1000004c.Brave Browser[93221]): Service exited with abnormal code: 7 in the logs, but not sure if that was from the browser exiting to upgrade or a failed attempt to relaunch. I didn't see any crash reports

[simonhong]

Need to check the difference between quit&open and relaunch. Quit & open doesn't have problem after installing update. Also need to check the copy timing of downloaded updates and it is related with this problem.

[simonhong]

Also, need to find how to update test on test server and how to build signed image(not sure it's possible on my local).

[w0ts0n]

FYI, team will look into this next week.

[simonhong]

I think sparkle isn't compatible with chromium's relaunch api.
Instead, we should use sparkle's own install and relaunch mechanism.

[LaurenWags]

Verified passed on macOS x64 10.12.6 when updating from 0.58.12 -> 0.58.14 on test channel.

Brave | 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Mac OS X

cc @kjozwiak for verification on his mac

Verification PASSED on macOS 10.14 x64 using the following build:

Brave | 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Mac OS X

• updated 0.58.12 --> 0.58.14 using the test channel x5 times without issues
• ensured that tabs/windows were being restored without issues
• ensured that bookmarks/password and other personal data was still intact