Brave-browser: Wallet activity - Monthly Statement

Created on 2 Sep 2018  路  22Comments  路  Source: brave/brave-browser

Implement wallet activity dialog that is triggered on rewards page in wallet section.

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QYes featurrewards prioritP2 release-noteinclude

All 22 comments

Please fix https://github.com/brave/brave-browser/issues/1298; closing #1298 as redundant

@NejcZdovc is this for the monthly statement for Brave Rewards?

@LaurenWags yes

@davidtemkin @mandar-brave @rebron is there any updates re: monthly statements? What's the current schedule for this? We really need to get this into the product. Right now, once you a-c, there's no way of knowing where exactly your BAT went as an end user. Getting several +1 from the community well. CCing @LaurenWags.

@jenn-rhim please add the final design for the monthly statements

Monthly statement update:

  1. For the statements dated prior to us keeping track of opening and closing balances: indicate NA
  2. Pending contribution list for unverified creators
  3. A case where no auto-contribute has gone out

statement-pendinglist

statement-noac

@NejcZdovc @mandar-brave

+1 from community - worked with a user via DM who funded their wallet and then it was used in Auto Contribute shortly thereafter (about 20 minutes), and without this feature it just looked like the BAT never made it to their wallet.

For QA, this is the latest design mockup I can find for this initiative.

image

@mandar-brave @jenn-rhim is the above mockup that @rossmoody mentioned in https://github.com/brave/brave-browser/issues/930#issuecomment-510224549 the latest design that will be used? Or is there something newer?

@kjozwiak i missed the tag on this.
I think it is in the ballpark with changes due to changes in product since design was agreed upon. @alexwykoff you probably are the best bet in terms of final final.

Thanks @mandar-brave 馃憤@alexwykoff if the above isn't the current design/spec, do we have an up to date one that we can add into the issue so once QA starts going through it, there's no discrepancies in what we see in the product vs the design documents?

marking as QA/Blocked until https://github.com/brave/brave-browser/issues/8828 is uplifted to 1.7.x

Verified passed with

Brave | 1.7.79 Chromium: 80.0.3987.149聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.14.6 (Build 18G3020)

  • Verified test plan from https://github.com/brave/brave-core/pull/4279
  • General cases executed:
  • Clean profile 1.7.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant

    • claim UGP grant

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

      ---> Monthly statement contains all expected information

  1. Clean profile 1.7.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information
  2. Clean profile 1.7.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information
  3. Upgrade - install 1.5.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information
  4. Upgrade - install 1.5.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information
  5. Upgrade - install 1.5.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information

Screen Shot 2020-03-31 at 1 49 24 PM
Screen Shot 2020-03-31 at 1 49 33 PM
Screen Shot 2020-03-31 at 1 49 41 PM
Screen Shot 2020-03-31 at 1 49 49 PM

Verification is in-progress

Brave | 1.7.81 Chromium: 80.0.3987.149聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)

  • Verified test plan from https://github.com/brave/brave-core/pull/4279

image
* General cases executed:
1. Clean profile 1.7.x (funded via UGP & Ad grants) - PASS
- claim UGP grant
- claim Ad grant
- set up & perform AC
- set up & perform recurring tips
- set up 1 time tips

---> Monthly statement contains all expected information - logged https://github.com/brave/brave-browser/issues/8963
image

  1. Clean profile 1.7.x (funded via KYC'd wallet) - PASS

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

---> Monthly statement contains all expected information - Logged https://github.com/brave/brave-browser/issues/8963

  1. Clean profile 1.7.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

---> Monthly statement contains all expected information
image

  1. Upgrade - install 1.5.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant

    • claim UGP grant

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

    • upgrade to 1.7.x

    • view monthly statement

---> Monthly statement contains all expected information
image

  1. Upgrade - install 1.5.x (funded via KYC'd wallet) - PASS

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

    • upgrade to 1.7.x

    • view monthly statement

---> Monthly statement contains all expected information Encountered #8963
image

  1. Upgrade - install 1.5.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

    • upgrade to 1.7.x

    • view monthly statement

---> Monthly statement contains all expected information

Verification passed on

Brave | 1.7.82 Chromium: 80.0.3987.162聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS | Ubuntu 18.04 LTS

  • Verified test plan from https://github.com/brave/brave-core/pull/4279
  • General cases executed:
  • Clean profile 1.7.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant

    • claim UGP grant

    • set up & perform AC

    • set up & perform recurring tips

    • set up 1 time tips

      ---> Monthly statement contains all expected information

  1. Clean profile 1.7.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information
  2. Clean profile 1.7.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information
  3. Upgrade - install 1.5.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information
  4. Upgrade - install 1.5.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information
  5. Upgrade - install 1.5.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement

image
image
image
image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

qingxiang-jia picture qingxiang-jia  路  3Comments

fmarier picture fmarier  路  3Comments

simonhong picture simonhong  路  3Comments

kjozwiak picture kjozwiak  路  3Comments

AlexCombas picture AlexCombas  路  3Comments