Brave-browser: Dynamically generated PDF does not load properly

[bsclifton]

Test plan

See https://github.com/brave/brave-core/pull/2342

Description

Carried over from https://github.com/brave/browser-laptop/issues/8687

Steps to reproduce

1. Try to load http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.105.6357&rep=rep1&type=pdf
2. Notice there is an error
3. Try same URL in Chrome and verify it works as expected

[btlechowski]

+1 from community. The user uses this feature for work.
https://community.brave.com/t/beta-crashes-accessing-sigma-aldrich-site/33524

The page contains dynamically generated pdf, which is placed in an iframe.

link to the page

[jasonrsadler]

Viewing paystubs on namely also produces invalid pdf structure error.

Viewing on browser-laptop works properly

[cndouglas]

+1 from brave/browser-laptop#15326.

[SilverPuppy]

I also use this for work. This hasn't worked correctly for years. I discovered it when Google Calendar, which my store uses, experienced this issue. I first had the problem in 2016. This was under the old brave-laptop codebase. How is the current codebase, a hacked up Chrome, still having this issue?

I'm being forced to keep FireFaux open to use GC, and I don't like that. EDIT: for the time being I've reinstalled 0.26. Be avenged, Mr. Eich! :)

[SilverPuppy]

This still is not working, so I'm assuming that for the time being this issue is being overlooked. My current workaround is simply to download instead of using PDF.js but this is a clunky solution. Is this going to be addressed any time soon? As shown by the duplicate bug I just marked, this is affecting more people than just me.

[megaroeny]

Not working for me either on Version 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)

[GeetaSarvadnya]

1+https://community.brave.com/t/the-usual-pdf-viewer-doesnt-work-on-some-pdf-links/36781/7

[GeetaSarvadnya]

1+ https://community.brave.com/t/cant-download-pdf-unexpected-response-from-server/51666/2

[Brave-Matt]

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/bm8xb3/issue_cant_scroll_using_mouse_in_pdfs/

[GeetaSarvadnya]

1+https://community.brave.com/t/pdf-will-not-open-due-to-invalid-pdf-structure/64623/2

[taylormade2k]

This issue is still persisting as of July 9th, 2019. I guess I will have to download chrome as a backup...

https://www.screencast.com/t/eaUUh0pwnXkD

[bsclifton]

@taylormade2k you are definitely welcome to try our Nightly version - it should be fixed there 😄
https://brave.com/download-nightly/

The fix will make it's way to the STABLE version of Brave on Aug 20th

[btlechowski]

Verification passed on

Brave | 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
-- | --
Revision | 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS | Windows 7 Service Pack 1 (Build 7601.24494)

Verified test plan from https://github.com/brave/brave-core/pull/2342
Also successfully opened links from the comments.

Verification passed on

Brave | 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
-- | --
Revision | 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS | Linux

• Verified document linked in test plan is opening as expected
  
• Verified links mentioned in the comment also opened as expected

Verified passed with

Brave | 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
-- | --
Revision | 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS | Mac OS X

• Verified test plan from https://github.com/brave/brave-core/pull/2342