Brave-browser: Create an about:adblock page

Created on 4 Jun 2018  路  4Comments  路  Source: brave/brave-browser

The first version would be very simple, you can follow along how about:payments is done for a simple example, or about:newtab is done in WebUI for a more complicated example.

It should be the same redux format as the newtab page.

The first version would just say the blocked count.
It would also indicate if a regional list is in use and if so which one it is.

Later we'll add more features to this page like custom filters.

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QYes featurshieldadblock featuruser-interface

All 4 comments

cc: @Snuupy

I was doing a task close to this code today so I just took this one too.

As described above, this task is just to get the page working, redux things setup, and display the block count, if region lists are enabled, and if so which one is being used. It's mainly for support for now until we add things like custom lists.

screen shot 2018-07-04 at 9 45 06 pm

Verification passed on

Brave | 0.55.5 Chromium: 70.0.3538.16聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Windows 7

image

Verification Passed on

Brave | 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Linux

image

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave | 0.55.6 Chromium: 70.0.3538.16聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Mac OS X

screen shot 2018-09-25 at 8 58 57 pm

  • ensured that typing about://adblock directly into the URL loads the page
  • ensured that typing chrome://adblock directly into the URL loads the page
Was this page helpful?
0 / 5 - 0 ratings