Boostnote: Editor themes aren't working since the new release

Created on 22 May 2019  路  35Comments  路  Source: BoostIO/Boostnote


Issuehunt badges

Since new release, editor themes are not working anymore. Only the default one is working.



IssueHunt Summary

awolf81 awolf81 has been rewarded.

Backers (Total: $100.00)

- #3048 Fix theme path issue

Tips

IssueHunt has been backed by the following sponsors. Become a sponsor


bug level 1 rewarded on issuehunt
Source
picture dudziecjacek
👍38

Most helpful comment

Fix in new release for Windows 7, on the advice of @bwarfson

Edit \boost\app-0.11.16\resources\app\compiled\main.js

Find :

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });

Changed path to:

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(CODEMIRROR_THEME_PATH, file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });
picture Octen on 23 May 2019
👍29 ❤7

All 35 comments

I have the same issue.

crockels picture crockels on 22 May 2019

I am also having this issue as well, the only one that seems to be working is the default 馃檭

Example of the problem:
Boostnote_2019-05-22_14-10-21

I am also seeing the following, not sure if that is normal or part of this issue?:
Boostnote_2019-05-22_14-10-59

Settings page:
image

OS: Windows 10
The version of Bootnote: Not sure how to pull this info but it asked me to update today.

CLGREEN94 picture CLGREEN94 on 22 May 2019

I have the same issue.
This reason is that the file path is wrong.
the issue

FYI: I think that is due to the following two lines.
https://github.com/BoostIO/Boostnote/blob/d5d564f789fc7b59abf9f253102297f6cfaf363d/browser/main/lib/ConfigManager.js#L138
https://github.com/BoostIO/Boostnote/blob/d5d564f789fc7b59abf9f253102297f6cfaf363d/browser/main/lib/ConfigManager.js#L180
I think that this issue will be fixed if ../ will be removed.

roottool picture roottool on 22 May 2019
👍4

Jep, same issue for me.

Qryptoc picture Qryptoc on 22 May 2019

I can confirm... it's broken

2019-05-22_15h43_33

TobseF picture TobseF on 22 May 2019

It's Broken on my side too, exact same issues!
Windows 10

jvaldiviezo9 picture jvaldiviezo9 on 22 May 2019

Broken for me too. I messed with it for a bit today and was was able to get it working by making a small change to consts.js. 

const themes = paths
  .map(directory => fs.readdirSync(directory).map(file => {
    const name = file.substring(0, file.lastIndexOf('.'))

    return {
      name,
      path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
      className: `cm-s-${name}`
    }
  }))

Changed path to:

const themes = paths
  .map(directory => fs.readdirSync(directory).map(file => {
    const name = file.substring(0, file.lastIndexOf('.'))
    return {
      name,
      path: path.join(CODEMIRROR_THEME_PATH, file),
      className: `cm-s-${name}`
    }
  }))
bwarfson picture bwarfson on 23 May 2019
👍6 ❤1

This doesn't happen on Linux.

ZeroX-DG picture ZeroX-DG on 23 May 2019
😕7

Broken for me too on Windows 10.

Ljiee picture Ljiee on 23 May 2019

Got the same issue (also source code theme is not working):

image

GreaTDog picture GreaTDog on 23 May 2019

On windows 10,
I find it can be fixed in boostapp-0.11.16resourcesappcompiledmain.js
line 2823
change to "editorTheme.setAttribute('href', theme.path);"

Thanks Ljee - it worked for me.

GreaTDog picture GreaTDog on 23 May 2019
👍2

However, I find it only works when I open boostnote. If I go to the preference and set the theme, it is invalid again.

Ljiee picture Ljiee on 23 May 2019

However, I find it only works when I open boostnote. If I go to the preference and set the theme, it is invalid again.

Have the same. Themes stop working after first preferences save.

GreaTDog picture GreaTDog on 23 May 2019

The same file, line 2867, change to "editorTheme.setAttribute('href', theme.path);" @GreaTDog, I think that might works.

Ljiee picture Ljiee on 23 May 2019

The same file, line 2867, change to "editorTheme.setAttribute('href', theme.path);" @GreaTDog, I think that might works.

Preferences 'Save' button now seems to be unresponsive. But it saves settings - need to restart boostnotes app to see changes. However the app is usable now - thanks again.

GreaTDog picture GreaTDog on 23 May 2019

I have same issue for me on Windows 10 since the new release

atez picture atez on 23 May 2019

Fix in new release for Windows 7, on the advice of @bwarfson

Edit \boost\app-0.11.16\resources\app\compiled\main.js

Find :

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });

Changed path to:

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(CODEMIRROR_THEME_PATH, file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });
Octen picture Octen on 23 May 2019
👍29 ❤7

Same issue for me. It's affecting Boostnote on both PCs I use.

grandslammer picture grandslammer on 25 May 2019

Same here on Windows 10 after installing the latest release.

irokin picture irokin on 27 May 2019

This is a very bad bug.why not fix it.

ebony0319 picture ebony0319 on 27 May 2019
👍6

On windows 10,
I find it can be fixed in boostapp-0.11.16resourcesappcompiledmain.js
line 2823
change to "editorTheme.setAttribute('href', theme.path);"

Thanks Ljee - it worked for me.

This worked for me on windows 10. But the line was 2436 for release 11.17.

refactoredjello picture refactoredjello on 27 May 2019
👍2

Fix in new release for Windows 7, on the advice of @bwarfson

Edit \boost\app-0.11.16\resources\app\compiled\main.js

Find :

  var themes = paths.map(function (directory) {
    return fs.readdirSync(directory).map(function (file) {
      var name = file.substring(0, file.lastIndexOf('.'));

      return {
        name: name,
        path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
        className: 'cm-s-' + name
      };
    });
  }).reduce(function (accumulator, value) {
    return accumulator.concat(value);
  }, []).sort(function (a, b) {
    return a.name.localeCompare(b.name);
  });

Changed path to:

  var themes = paths.map(function (directory) {
    return fs.readdirSync(directory).map(function (file) {
      var name = file.substring(0, file.lastIndexOf('.'));

      return {
        name: name,
        path: path.join(CODEMIRROR_THEME_PATH, file),
        className: 'cm-s-' + name
      };
    });
  }).reduce(function (accumulator, value) {
    return accumulator.concat(value);
  }, []).sort(function (a, b) {
    return a.name.localeCompare(b.name);
  });

Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.

amizan8653 picture amizan8653 on 29 May 2019

Fix in new release for Windows 7, on the advice of @bwarfson
Edit \boost\app-0.11.16\resources\app\compiled\main.js
Find :

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });

Changed path to:

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(CODEMIRROR_THEME_PATH, file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });

Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.

my version is 0.11.17 and Octen's solustion is still work for me. I'm running on windows 10 too.

loner233 picture loner233 on 30 May 2019

Fix in new release for Windows 7, on the advice of @bwarfson
Edit \boost\app-0.11.16\resources\app\compiled\main.js
Find :

  var themes = paths.map(function (directory) {
    return fs.readdirSync(directory).map(function (file) {
      var name = file.substring(0, file.lastIndexOf('.'));

      return {
        name: name,
        path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
        className: 'cm-s-' + name
      };
    });
  }).reduce(function (accumulator, value) {
    return accumulator.concat(value);
  }, []).sort(function (a, b) {
    return a.name.localeCompare(b.name);
  });

Changed path to:

  var themes = paths.map(function (directory) {
    return fs.readdirSync(directory).map(function (file) {
      var name = file.substring(0, file.lastIndexOf('.'));

      return {
        name: name,
        path: path.join(CODEMIRROR_THEME_PATH, file),
        className: 'cm-s-' + name
      };
    });
  }).reduce(function (accumulator, value) {
    return accumulator.concat(value);
  }, []).sort(function (a, b) {
    return a.name.localeCompare(b.name);
  });

Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.

my version is 0.11.17 and Octen's solustion is still work for me. I'm running on windows 10 too.

Worked for me also..!

guruathwal picture guruathwal on 30 May 2019

Fix in new release for Windows 7, on the advice of @bwarfson
Edit \boost\app-0.11.16\resources\app\compiled\main.js
Find :

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });

Changed path to:

    var themes = paths.map(function (directory) {
      return fs.readdirSync(directory).map(function (file) {
        var name = file.substring(0, file.lastIndexOf('.'));

        return {
          name: name,
          path: path.join(CODEMIRROR_THEME_PATH, file),
          className: 'cm-s-' + name
        };
      });
    }).reduce(function (accumulator, value) {
      return accumulator.concat(value);
    }, []).sort(function (a, b) {
      return a.name.localeCompare(b.name);
    });

Octen's solution worked for Boostnote version 11.16. When updated to ver 11.17, the fix no longer works sadly. I'm running on windows 10.

my version is 0.11.17 and Octen's solustion is still work for me. I'm running on windows 10 too.

Worked for me also..!

Ah.... I tried Octen's solution again on my home windows 10 computer and it works... I probably just did something stupid on my work computer, like changing the file boost\app-0.11.16\resources\app\compiled\main.js instead of boost\app-0.11.17\resources\app\compiled\main.js. Sorry guys

amizan8653 picture amizan8653 on 31 May 2019

Broken for me too. I messed with it for a bit today and was was able to get it working by making a small change to consts.js.

const themes = paths
  .map(directory => fs.readdirSync(directory).map(file => {
    const name = file.substring(0, file.lastIndexOf('.'))

    return {
      name,
      path: path.join(directory.split(/\//g).slice(-3).join('/'), file),
      className: `cm-s-${name}`
    }
  }))

Changed path to:

const themes = paths
  .map(directory => fs.readdirSync(directory).map(file => {
    const name = file.substring(0, file.lastIndexOf('.'))
    return {
      name,
      path: path.join(CODEMIRROR_THEME_PATH, file),
      className: `cm-s-${name}`
    }
  }))

I was unable to export file as html, this update worked for me as well. Note, path for version used was "C:UserszhumphreyAppDataLocalboostapp-0.11.17resourcesappcompiled".

Boostnote version 11.16 updated to version 11.17 on Windows 10.

wacsintegra picture wacsintegra on 6 Jun 2019

@boostio has funded $80.00 to this issue.

IssueHuntBot picture IssueHuntBot on 7 Jun 2019

Changing the path as suggested also worked for me on win 10.

Should this be provided as a PR? Any reasons why this is not done yet?

michaelw85 picture michaelw85 on 13 Jun 2019

@michaelw85 There's a PR for that (waiting to be merged): https://github.com/BoostIO/Boostnote/pull/3048

ZeroX-DG picture ZeroX-DG on 13 Jun 2019

@ZeroX-DG Ok great! I overlooked the PR linked to this issue, it's somewhere in the middle of the thread 馃槄.

michaelw85 picture michaelw85 on 14 Jun 2019

Great! Octen's Solution also worked for me. Thank u very much.@Octen
Running Boostnote 0.11.17 on Windows 10.

RunningIkkyu picture RunningIkkyu on 27 Jun 2019

Thanks, @Octen. Your fix worked for me (0.11.17, Win 10). This had been bothering me for at least a couple of weeks now.

gator-mk picture gator-mk on 29 Jun 2019

@elliptic-shiho has funded $20.00 to this issue.

issuehunt-app[bot] picture issuehunt-app[bot] on 3 Jul 2019

The fix for this #3048 has been merged and will be part of the next release 0.12.0

Flexo013 picture Flexo013 on 17 Jul 2019

@rokt33r has rewarded $90.00 to @awolf81. See it on IssueHunt

  • :moneybag: Total deposit: $100.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $10.00
issuehunt-app[bot] picture issuehunt-app[bot] on 18 Jul 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Rokt33r picture Rokt33r  路  3Comments
shunchuan picture shunchuan  路  3Comments
NonlinearFruit picture NonlinearFruit  路  3Comments
croulibri picture croulibri  路  3Comments
lijinglue picture lijinglue  路  3Comments