Bookplayer: Library: Enable Search

Created on 18 May 2018  路  6Comments  路  Source: TortugaPower/BookPlayer

Extracted from #46

enhancement

Most helpful comment

OK. I'll start down this road and PR something in the next few weeks that you all can take a look at.

All 6 comments

Moving this to a later milestone, we need features for later 馃槃

moving this back to later, I want to focus on the watch app

I'm interested in tackling this one. Few questions:

  • Do you want search to simply filter the library list based on the results (as opposed to using a search results controller with a different layout)?
  • The searchController property on UINavigationItem was introduced in iOS 11. Do you have a preferred approach for adding the search bar for iOS 10 (such as a floating search bar attached to the top of the tableview or adding the search bar to the tableview header view)?
  • Since the app simply fetches all items from CoreData and populates an array with them, I'm assuming a search function would just filter this array post-fetch, as opposed to performing the search as part of a CoreData fetch request?

That would be great @clint015 !

  • Regarding how the filtered results and the search bar should look, I'll defer to @pichfl .
  • Regarding the searchcontroller and the property on UINavigationItem it should be fine to go that way, we should also up the minimum version to iOS 11 as well (we've discussed this before and now should be a good time to do it)
  • Regarding filtering post-fetch, yup, since we got all those things in memory, we might as well filter those instead of doing a coredata fetch request

I'd use the same item layout for the results for now. If possible it would be neat to highlight the search term in the labels of the cell, but it's not necessary.

After discussion with @GianniCarlo I think we can move to iOS 11 as a baseline, which supports devices that were released >6 years ago, giving us an opportunity to use a more modern UI.

I'm not sure about the filtering, does this find items inside Playlists as well? If yes, I'm totally fine with that approach.

OK. I'll start down this road and PR something in the next few weeks that you all can take a look at.

Was this page helpful?
0 / 5 - 0 ratings