Bookplayer: First chapter starts when tap on the image of the playlist in the Library list

Created on 5 Feb 2019  路  6Comments  路  Source: TortugaPower/BookPlayer

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    When I press on the image of the book in the library it brings me a player with a first chapter

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo / screenshot / screen recording of the problem.
    Open some book on any chapter, then open library and press on the book image - it starts the first chapter. Can share the video if that鈥檚 not reproducible, but later when I will get to the laptop.

  • What is the expected behavior?
    It should open player view with current state.

  • What is the motivation / use case for changing the behavior?
    It loses entire progress and start the book from the first chapter, don鈥檛 think it is intentionally

  • Please tell us about your environment:

    • Version of BookPlayer 3.2.1
    • Your Device and its OS version IPhone 7+, 12.2
  • Other information
    Can help with this as well if you need spare hands
bug

Most helpful comment

Looks like a proper bug then, we'll keep this issue updated when we find a fix.

In the mean time I recommend the same as I did in your other issue: Use one of the free converters to collect the mp3 files into a m4b type audiobook, naming the chapters in the process.

All 6 comments

It'd be of great help if you could provide a recording 馃憤, I'll be able to do some tests much later today and report back

Sorry, just read it opens first unfinished chapter, and somehow I had chapter 1 just a few seconds behind being finished. Though continuing from the current state looks more logical for me, but that's not a big deal, thanks for the fast reply!

Seems it is still reproducible even if I marked all chapters as read explicitly, please check the video :

  1. All the files are "read" up to chapter 21.

  2. When going back to the library and pressing on the artwork - chapter 1 is opened.

  3. Marking chapter 1 as read again - just to be sure.

  4. Open chapter 21.

  5. Going back to the library and pressing on the artwork - chapter 1 is still opened.

Very important question:
The chapters you're talking about, are they inside a single file or is each file a single chapter? The former would have files A-C with A containing Chapter 1-10, B containing Chapter 11-20, C containing 21-26, the latter having files A-Z with A being Chapter 1, and so on.

@GianniCarlo I think this may be solved by #276. I'm rather sure the error would be in this part of the model, which was my naive approach to finding the first unfinished file.
https://github.com/TortugaPower/BookPlayer/blob/6be02e1b427ee9e5a6620821fd35605d586fcd0b/BookPlayer/Models/Playlist%2BCoreDataClass.swift#L132-L142

I'm pretty sure this is the culprit:
https://github.com/TortugaPower/BookPlayer/blob/6be02e1b427ee9e5a6620821fd35605d586fcd0b/BookPlayer/Models/Book%2BCoreDataClass.swift#L41-L45

@pichfl thanks for the explanation, it is a one chapter per file

Looks like a proper bug then, we'll keep this issue updated when we find a fix.

In the mean time I recommend the same as I did in your other issue: Use one of the free converters to collect the mp3 files into a m4b type audiobook, naming the chapters in the process.

Was this page helpful?
0 / 5 - 0 ratings