Bookmarks: Allow Sorting

Created on 10 Apr 2013  Â·  27Comments  Â·  Source: nextcloud/bookmarks

Expected behaviour :

The user might be able to sort his bookmarks by name, creation date, tag, ... (see Google Bookmarks or ownCloud Tasks). It would be nice if either a clickable columnheader or a series of buttons allows custum sort order.

ref owncloud/apps#811

design enhancement good first issue

Most helpful comment

I’m a CS student and for this semester I have to work on an open-source project.
I think that I could work on this issue. Can I give it a try?

All 27 comments

If, then only by clickable column header. Please no extra buttons. :)

On 10.04.2013, at 22:26, eMerzh [email protected] wrote:

Expected behaviour :

The user might be able to sort his bookmarks by name, creation date, tag, ... (see Google Bookmarks or ownCloud Tasks). It would be nice if either a clickable columnheader or a series of buttons allows custum sort order.

ref owncloud/apps#811

—
Reply to this email directly or view it on GitHub.

I personnaly don't use that ... but it was requested by some users....

the thing is that i currently don't have any column header so i'll have to add some :)

+1 for sorting.

At least make alphabetical sorting by title the default behaviour.

The default should be date added, most recent up top. Alphabetical sorting makes little sense here.

Oh and btw, don’t use the current ownCloud Tasks as an example of how to implement sorting! It’s a whole mess of buttons which are super confusing.

IMHO sort by date will be extremely confusing if you have a lot of bookmarks.

Bookmark apps like Delicious, Pocket, etc – all sort by date. Alphabetic sorting is a shitty default for almost any app, except a dictionary. And even there, you would prioritize recently or often looked up words after some time.

Alphabetic sorting is a shitty default for almost any app

That's a matter of opinion.

Sorting by date added is pointless - in my opinion.

I'd like to see alphabetical sorting by name/title, it would be a very useful feature for me.

It would be interesting to see some kind of poll on this, possibly broken out by app. Personally I almost always want to see my most recently used bookmarks / files / contacts etc. If I want to find something by name, I tend to use the search bar (although it frustrates me that when a folder has loads of files, search just dumps me in the folder without hilighting the specific file ).

If we could sort bookmarks by column heading (like we can Files), then everyone would be happy as they could sort by title, date added, etc.

Yup.

The ability to sort would increase the usefulness of the bookmarks app a lot for me. Sorting by all column headings would be perfect, otherwise I'd prefer also a simple and fixed sorting by date added.

Currently the Bookmarks app is unfortunately unmaintained. Hence discussion here is of no use.

If someone of you wants to pick it up, please go ahead – and join us in the #owncloud-dev channel on IRC.

+1 for alphabetical order.

Maybe an option for sorting in the addon settings would be
a (temporary) solution. I personally would leave it on alphabetical
order by title. I think, people don't change that setting very often,
so such an option would do it.

I propose to add usage/click counter for every bookmark and order by that counter by default. This would basically be a "top/favourite sites" feature. I miss this in basically every bookmark manager app I've found so far.

I’m a CS student and for this semester I have to work on an open-source project.
I think that I could work on this issue. Can I give it a try?

Hey @chiotisn :)
Awesome! We can always use a helping hand. I'm not sure if it'll be enough work for a whole semester, but then, we never run out of issues ;)
Just FYI, we're currently working on a new UI (see #424), so it would make sense to base your work on that, once the PR is merged :)
And if you have any questions, feel free to email me or create an issue. :)

Cheers!

I know this is a 5 year old issue, but I'd like to give a +1 to the idea of better sorting. I get it that some (most? All but me?) folks want their bookmarks sorted by last use, but I just don't understand that behavior at all. When I want a bookmark, I think...Oh...I need the bookmark for Google...let me look at the letter G in my long, long list of bookmarkes.... Even categories, although useful have their issues... Is my google link in "utilities" or "email links" category? Let's say I realize it's in utilities...well, I've got 75 links in that category..and they are not alphatized... I need a way to find my google link quickly, not to think when I used it last... it just doesn't make any sense to me. For the folks that want their bookmarks sorted by last use....why? how do you find anything? Am I just wired differently from other folks? Do I have a paradigm that's just off? Anyhow, plus one for a different sort ability for this app....it's got so much potential, but drives me crazy as is....

@Hylas01 With the new UI you'll at least be able to search for "Google" (theh), but we do have attributes that would make sense to sort by, e.g. sort by most used (@atroxix we already have that built-in, but it's not used anywhere, surprisingly). It shouldn't be too hard to whip a PR for this with the new UI. @chiotisn I would happily give you directions on how to do this, so you could familiarize yourself with the codebase :)

@marcelklehr Thank you! I have seen the click-counting functionality. Currently, I’m trying to understand how all the components are connected, because I’m a beginner in php and in large applications but I will figure it out.

@chiotisn (replying here for posterity ;)) I think a settings entry would be a good idea for this feature as it seems most people will not change this very often and it's not very suitable for an entry in the menu either.

For persisting the setting there's the config interface the usage of which can be seen in the calendar app: [1] [2]

To send an Ajax request to the controller I have to create a Settings Model, right? Or I can send it from the settings view?

It probably makes sense to have a settings model, yea. Then you can implement a private settings controller on the server that handles CRUD operations on the settings entries. This obviously raises the burden on your part, but makes it easy to add new settings in the future :)
Adding sorting functionality is not that trivial after all, it seems :D

@marcelklehr thank you for your fast response! I think that the problem was that I had to get familiar with php and Marionette. I hope I will have it ready by Monday!

I’m currently writing tests to test my code, but I have problem running PHPUnit tests.
I type:
phpunit -c tests/phpunit.xml —bootstrap vendor/autoload.php
But php can’t find TestTestCase class in TestCase.php

Is there anything else that I should do before running tests?

Patch has landed. Thanks for your good work, @chiotisn :tada:

Hello,
my wishlist would include (by priority)

  • Sorting by Tag (without leading floccus:... if possible)
  • Export / Import with Tags
  • Favorites (*, **, *)
  • Sorting by Favorites
    Thank you for your work!
Was this page helpful?
0 / 5 - 0 ratings

Related issues

sunjam picture sunjam  Â·  4Comments

lyallp picture lyallp  Â·  4Comments

saywebsolutions picture saywebsolutions  Â·  6Comments

kaffeeringe picture kaffeeringe  Â·  6Comments

sunjam picture sunjam  Â·  5Comments