Blueprint: Version 3.31.0 breaks InputGroup with redux form

[tgreen7]

Environment

• __Package version(s)__: 3.31.0

Code Sandbox

working on 3.30.1
https://codesandbox.io/s/blueprint-sandbox-forked-n039t?file=/src/index.tsx

broken on 3.31.0
https://codesandbox.io/s/blueprint-sandbox-forked-327mz?file=/src/index.tsx

Steps to reproduce

1. Type in the input field in the sandbox
2. Move cursor to beginning of the input and type again. Cursor jumps to the end of the input on version 3.31.0

Possible solution

Version 3.31.0 added the asyncControllableInput

[tnrich]

Ya it seems like https://github.com/palantir/blueprint/pull/4266 changed how async updates fired. This is definitely an issue for us

[adidahiya]

@tnrich are you also using redux-form? curious if you are able to demonstrate a repro without using any external libraries

[tnrich]

@adidahiya yes also using redux-form. I haven't tried to replicate outside of a redux-form context

[adidahiya]

It looks like these issues: https://github.com/facebook/react/issues/955 and https://github.com/facebook/react/issues/14904. I'm going to try the workaround in https://github.com/facebook/react/issues/14904#issuecomment-522213842:

What I've done to workaround is to make the uncontrolled (change value to defaultValue) with a onChange prop.

[tnrich]

Thanks @adidahiya hopefully that works! Let us know when we can test out the new version.

[adidahiya]

Update: using defaultValue all the time doesn't work, it is incompatible with a controlled API for InputGroup / NumericInput. Investigating other approaches.

[tnrich]

Thanks @adidahiya let us know how it goes!

[adidahiya]

I tried many different approaches and all were unsuccessful. You can see my progress at #4323. At this point I don't have a good path forward, and we are not hitting this issue with our internal applications. Maybe it's an anti-pattern to control inputs asynchronously like redux-form does? If you can come up with a solution which does not cause a regression for the issue described in #4262, I'm all ears.

[ejose19]

@adidahiya What about a prop to opt-out of the asyncControllableInput? As the change in #4266 was pretty trivial, a switch should be straightforward. Although there are better form libraries for react, a lot of people still use redux-form (which is not recommended on the usual cases as stated by the author)

[adidahiya]

I took another pass at a (slightly complicated) solution with fresh eyes, and I think I've got something working in https://github.com/palantir/blueprint/pull/4323. I don't really want Blueprint users to have to think about toggling between async-capable inputs (which work around the IME composition bug) and regular inputs (which don't), because that choice would be hard to make across a software platform. The InputGroup building block should work for all locales out of the box.

[adidahiya]

@tnrich @tgreen7 @ejose19 could you try out the latest release to verify the fix? It seems to work in the scenario from the initial code sandbox linked at the top of this thread, see my fork: https://codesandbox.io/s/blueprint-4298-fix-verification-vjz7n

[tnrich]

@adidahiya I think it is working for us as far as we can tell. Can verify that the sandbox works as expected now. Thank you 🙏 🙏

[adidahiya]

4323 caused a regression for synchronous updates, so I have opened a PR to make async control optional. This will be a slight breaking change since you will need to enable the new prop manually in places where you expect async updates. PR is here: #4383