Blockscout: Add Internal Transaction type to the tile

Created on 17 Oct 2018  路  10Comments  路  Source: blockscout/blockscout

Internal transactions do not currently show the type (call, create, suicide, reward) from the database. This information is vital and should be displayed on the card.

  1. Display the type on the left side of the card under Internal Transaction
    internalleft

  2. If the type is call, display the call_type (delegate call, call)

  3. Make the changes on the transaction details page and address page internal transactions tab.

enhancement good first issue high contributor

Most helpful comment

@Lucasnar, you have been approved to work on this bounty. Please start at your earliest convenience :)

All 10 comments

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund.__

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work has been started__.

These users each claimed they can complete the work by 7聽months, 1聽week from now.
Please review their action plans below:

1) lucasnar has been approved to start work.

Action Plan

  • Update the InternalTransaction tile partial to include the type information. This information is available in the InternalTransaction struct;
  • Adjust any style that could end up being messed by this addition to the card.

Questions

  • Should we state that what we are showing is the type. In other words, should we display Type: create or just Create under Internal Transaction?

    • Similarly, when it is an internal transaction of type call, would we go with Call Type: call , or just Call?

  • When it is an internal transaction of type call, where should we display the call type? Suggestions: we could have a dash separating the type and the call type, or put the call type between brackets.

Learn more on the Gitcoin Issue Details page.

@Lucasnar, you have been approved to work on this bounty. Please start at your earliest convenience :)

@acravenho, which option would you choose for displaying the type?


Option 1

image


Option 2

image

Or maybe you would like another way?

@Lucasnar I'm thinking option 2 but maybe with some type of highlighting or parenthesis.

What could the highlighting be? I tried bold text. Here is an example of parenthesis and turning the text bold:


Parenthesis

image


Bold

image

I like parenthesis :smile:

Ok! 馃檪
I'm going to open a PR later with parenthesis. If you have any other option you'd like to go with, let me know.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by__:

  1. @Lucasnar

@mkosowsk please take a look at the submitted work:

  • PR by @Lucasnar

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @Lucasnar.__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dwalintukan picture dwalintukan  路  4Comments

pedrouid picture pedrouid  路  4Comments

zulhfreelancer picture zulhfreelancer  路  6Comments

SVINCHAIN picture SVINCHAIN  路  3Comments

dwalintukan picture dwalintukan  路  5Comments