This issue is intended to continue the work from #168.
An initial set of tasks would include:
Hey, @igorffs! I've tested the verification process for some Solidity versions and everything seems to be working as expected! :tada:
The only issue I found was the following one: in the verification page, if I select the versions 0.1.1, 0.1.2 or 0.1.3 and click to verify, I'm redirected to a Phoenix error page.
That happens every time I try to verify a code choosing one of those 3 versions, except in one case: when I try to verify a contract that was actually created with 0.1.3 version and I select exactly that version. The error message is the one below:
no match of right hand side value (lib/explorer/smart_contract/solidity/code_compiler.ex line 84)
Regarding the 0.1.1 and 0.1.2 versions, maybe we could remove them from the options since we're not going to support them, as we talked at standup some days ago. Wdyt?
Thanks @gfreh!
I agree that we should remove the 0.1.1 and 0.1.2 from the list. 馃憤 And 0.1.3 error scheme is probably different from the other versions. I'll take a look so we can avoid the Phoenix error page in this scenario. 馃憤
@igorffs I tested it this morning and now everything seems fine! I'm moving it to Ready for Acceptance.
@acravenho would you like to take a look in it?
LGTM!!! 馃憤
The issue is solved and accepted thus I'll close it.