Bloc: VSCode refactor menu

Created on 24 Jul 2019  路  7Comments  路  Source: felangel/bloc

I just wonder if VSCode refactors menu is flutter default items only or we could modify it for adding wrap with a new BlocBuilder?
Or we should ask in flutter repo itself?

image

dependency enhancement candidate extension

All 7 comments

I open an issue on flutter repo
https://github.com/flutter/flutter/issues/36803

Hey @amreniouinnovent 馃憢
Thanks for opening an issue!

I've been thinking about adding this for a while but I believe the right place to add this would be in the dart vscode extension. Might be a good idea to open an issue there for starters.

@felangel I didn't know about that repo
I opened an issue there
https://github.com/Dart-Code/Dart-Code/issues/1890

@amreniouinnovent thanks! It's likely the maintainers will say the functionality doesn't belong there because it isn't part of core Dart/Flutter so if that's the case, I'll add it to the bloc VSCode extension 馃憤

It's likely the maintainers will say the functionality doesn't belong there because it isn't part of core Dart/Flutter so if that's the case, I'll add it to the bloc VSCode extension 馃憤

It's kinda tricky.. I like the idea, but it does feel a bit specific (even in a generic JSON form). However I'm not sure other extensions have a great way to know when it's the correct place to show the item in the menu (or fetch the edits) without making assumptions about how the Dart extension works.

I added a question at https://github.com/Dart-Code/Dart-Code/issues/1890#issuecomment-514512417 asking for a little more clarification on how this works (I'm not very familiar with what the code you want to insert looks like).

I will close this issue as it is now opened in https://github.com/Dart-Code/Dart-Code/issues/1890

This is now supported in v5.1.0 of the bloc extension 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rsnider19 picture rsnider19  路  3Comments

timtraversy picture timtraversy  路  3Comments

MahdiPishguy picture MahdiPishguy  路  3Comments

tigranhov picture tigranhov  路  3Comments

Reidond picture Reidond  路  3Comments