Bloc: A couple of problems with the TODOs tutorial.

Created on 26 May 2019  路  3Comments  路  Source: felangel/bloc

Just a couple of small problems on https://felangel.github.io/bloc/#/fluttertodostutorial, that newcomers might find hard to tackle.

  1. Missing implementation of ExtraAction enum (I suppose it should go in the models dir under the filename extra_actions.dart and then be exported via models.dart Edit: actually the implementation is already present in the repository, it's just that it isn't mentioned anywhere in the actual tutorial page.

  2. The files flutter_todos_keys.dart and localization.dart are both in the repository of the tutorial but are not mentioned anywhere on the actual page.

Apart from that, I just want to say BIG thanks and great job. I highly appreciate the time and effort put into this piece.

enhancement example

Most helpful comment

@felangel quick to react! Maybe a bit too quick - missing a closing bracket for class FlutterTodosKeys in the code block for the keys... but I'm sure that's intentional, as one should always practice debugging such simple issues 馃槃

All 3 comments

Hi @komapeb 馃憢
Thanks so much for opening an issue and for the positive feedback!

I've tried to address your feedback in https://github.com/felangel/bloc/commit/17ba340b2232fe47dd6a069596ad1016dafcbeb6.

You should be able to refresh the tutorial documentation and see the new sections for keys and localization as well as the ExtraAction enum definition.

Thanks again 馃挴

@felangel quick to react! Maybe a bit too quick - missing a closing bracket for class FlutterTodosKeys in the code block for the keys... but I'm sure that's intentional, as one should always practice debugging such simple issues 馃槃

@komapeb that was my bad 馃槄

Thanks for catching that...should be all good now 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ctippur picture ctippur  路  3Comments

tigranhov picture tigranhov  路  3Comments

nhwilly picture nhwilly  路  3Comments

rsnider19 picture rsnider19  路  3Comments

krusek picture krusek  路  3Comments