Bitshares-core: Fund account on account creation

[clockworkgr]

As a faucet operator I want to be able to fund accounts on creation so that newly created accounts can contain a balance without having to wait for the account creation operation to be in LIB before performing a transfer.

CORE TEAM TASK LIST

• [ ] Evaluate / Prioritize Feature Request
  
  
  
  • [x] Draft BSIP: @clockworkgr @cogutvalera
  
  
  • [ ] Approve draft
  
  
  • [ ] Vote BSIP for implementation
  
  
• [ ] Refine User Stories / Requirements
• [ ] Define Test Cases
• [ ] Design / Develop Solution
• [ ] Perform QA/Testing
• [ ] Update Documentation

[clockworkgr]

Related: https://github.com/bitshares/bitshares-core/issues/1398

[sschiessl-bcp]

Many gateways have been asking for this kind of feature, and it would be extremely helpful as well for all the "Insufficient funds" support requests for not properly maintained fee pools.

The testnet faucet is also supporting that, but via a separate transfer after account creation, which is error prone.

+1

[xeroc]

That would be helpful to the testnet faucet too, which gives every new account x TEST for, well, testing ... :)

@stefan: that script is not error prone - ever. I wrote it :D :D :p

[cogutvalera]

@ryanRfox I want to implement this feature a bit later :) claiming it now if possible, just wanted to mention it ...

Thanks !

[clockworkgr]

that was fast :P

[pmconrad]

Please write a BSIP.

[clockworkgr]

ok. will do

[ryanRfox]

Yes, BSIP is the proper next step. @cogutvalera love the enthusiasm. Hope you are willing to assist with drafting the spec.

[cogutvalera]

@ryanRfox yes sure thank you !

[abitmore]

As mentioned in Telegram:

• perhaps good to have a list of asset objects (asset_id+amount);
• need to honor asset authorization settings (e.g. whitelisting)

[oxarbitrage]

I like the idea, it is somehow related to something we discussed about approving a proposal at the same time as creating it(dont remember if we have an issue for this)

[clockworkgr]

As mentioned in Telegram:

• perhaps good to have a list of asset objects (asset_id+amount);
• need to honor asset authorization settings (whitelisting)

second part should be quite easy....if an asset simply has a whitelist....it can't be there...
as account hasn't been created yet, it can't be whitelisted.

[abitmore]

@clockworkgr asset authorization is not only whitelisting. My bad for didn't state it clearly. IMHO we need to mention it in the BSIP, but don't need to go into details about it.

[btsabc]

It looks like we can test the consistency of account_id and name or the consistency of asset_id and symbol etc by modifying or adding predicate in assert_operation.

https://github.com/bitshares/bitshares-core/blob/3ea52879d634f0bd5bca80e6059b9308ba3270ff/libraries/chain/assert_evaluator.cpp#L33-L71

[abitmore]

@btsabc yes a faucet can do that, but also with downsides:

• current fee for assert_operation is expensive;
• the account creation operation or the transfer will be broadcast then fail which is not user-friendly.