Bitshares-core: Account_history plugin: filtering by account doesn't work

[abitmore]

Witness node has an option:

Options for plugin account_history:
  --track-account arg                   Account ID to track history for (may
                                        specify multiple times)

By using this option, a witness node is expected to track specified account(s) only, so it will use less memory.

It doesn't work right now.

[vikramrajkumar]

I am thinking that since it appears nobody was using this, to just remove this option to make the code simpler. Any objection?

[TheTaconator]

I have no objection to removing this option. However, does not PR #259 fix this issue?

[abitmore]

The option is designed for exchanges, although none of them was effectively using it since it's broken, we don't know whether someone's business will be broken if we removed it. So my opinion is to keep it at least for backward compatibility.

I've patched all my non-API nodes, running with a config track-account = "1.2.1", now they consume ~1GB less RAM than before. So I think that option is useful so far. For non-API nodes (validation-only nodes, block producing nodes and etc), it's better if we can disable the plugin directly (to save some RAM).

[elmato]

I'm testing a "track-reg-by" parameters that only tracks the account
history if the account was registered by a specific account.

Maybe openledger can make use of this parameter to be sure that their
customers always get served, but exchanges like poloniex can't rely anymore
in the node having all the history available (if they are using it).

I don't want to derail the conversation but we should start separating the
"full node" architecture (all in memory) from the "api node" architecture.

On Wed, Apr 12, 2017 at 12:00 PM, Abit [e-mail] wrote:

The option is designed for exchanges, although none of them was
effectively using it since it's broken, we don't know whether someone's
business will be broken if we removed it. So my opinion is to keep it at
least for backward compatibility.

I've patched all my non-API nodes, running with a config track-account =
"1.2.1", now they consume ~1GB less RAM than before. So I think that
option is useful so far. For non-API nodes (validation-only nodes, block
producing nodes and etc), it's better if we can disable the plugin directly
(to save some RAM).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bitshares/bitshares-core/issues/258#issuecomment-293605537,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOUokCuFWjw8Wxi8IkN-vRKwLr8DMkZks5rvOcdgaJpZM4M32xk
.

[TheTaconator]

@abitmore, for my understanding, does PR #259 fix this issue? If not, what does it do?

[abitmore]

Fixed. Closing.