Bitshares-core: Editline can't work under MSVC

[xiangxn]

Editline can't work under MSVC

[jmjatlanta]

I believe the readline/editline libraries only worked in *nix-type OSs. And that continues to be the case. Is it causing a compiler or runtime error? Or is it simply not working?

If it is a compiler or runtime error, it will need to be fixed quickly.

If the functionality is simply not there, we will have to wait until editline code for Windows is developed and implemented.

[abitmore]

It doesn't compile due to use of sys/ioctl.h and etc. I'd suggest that we skip compiling it for now. I'm working on a patch.

[jmjatlanta]

I believe one problem is bitshares-fc's CMakeLists.txt line 117. Removing "COMPILE_DEFINITIONS" allowed cmake to run. Still testing.

[xiangxn]

You can consider using wineditline instead of editline in windows, but you have to modify a lot of code, or give up some functions.

[xiangxn]

If there is time and manpower, we should use MSYS to compile the execution files under Windows, so that the initial work will be larger, but there will be less cross-platform compatibility issues.

[abitmore]

@jmjatlanta how did it compile for your?

librariesfcvendoreditlinesrceditline.c(25): fatal error C1083: Cannot open include file: 'sys/ioctl.h': No such file or directory

@xiangxn check this: https://github.com/bitshares/bitshares-core/issues/738, it's even easier.

[abitmore]

I want to skip editline in MSVC so far: https://github.com/bitshares/bitshares-fc/pull/34. Please check.

By the way, please check https://github.com/bitshares/bitshares-fc/pull/32 as well, which enables building with GCC 4.8.

[jmjatlanta]

Your change https://github.com/bitshares/bitshares-fc/pull/34 works with MSVC.

[jmjatlanta]

Check out https://github.com/AmokHuginnsson/replxx

Small, BSD licensed, compatible with Linux, Mac, and Windows.

Update: It seems the UTF-8 portion of replxx uses a header that is not BSD compatible. Researching to see if there is a fix for this or a different library with similar functionality.