Betonquest: Color of text in "chest" conversations

[Momonche]

When I add a color in my text, it's stange.

[MWFIAE]

Please be more specific what exactly is strange.
What did you expect?
What is written in you config?

[Momonche]

The text
is written
like that
after the
color symbol.
I just write a color symbol in my textt, nothing else.

[joblo2213]

Can we have a look at your config file so that I can try reproducing it?
It would be also interesting to know which version you are using...

[Momonche]

quester: "Tuto"
stop: "false"
first: "start,start2,start3,start4"
NPC_options:
  start:
    text: "Pour prendre une quête vous devrez discuter avec les PNJ donneurs de quê\
      te ! Ceux-ci auront \"Quête disponible\" marqué au dessus de leur tête s'ils\
      \ ont une quête à vous proposer, en &e&ojaune&a&o si c'est une quête répétable\
      \ et en vert si vous ne pouvez faire la quête qu'une seule fois. Vous aurez\
      \ des options de conversation, qui auront des effets différents. Par exemple,\
      \ ici vous pouvez choisir de me dire de continuer, ou vous en aller ! Vous pouvez\
      \ aussi fermer l'inventaire si vous voulez interrompre la conversation sans\
      \ choisir."
    conditions: "!has_start_tag"
    pointers: "start1_ok,start1_shutup"

BetonQuest version 1.9.6

[Momonche]

The Config File

version: v51
mysql:
  host: ''
  port: ''
  user: ''
  pass: ''
  base: ''
  prefix: betonquest_
language: fr
update:
  enabled: false
  download_bugfixes: false
  notify_new_release: true
default_journal_slot: '-1'
max_npc_distance: '5'
default_conversation_IO: chest
display_chat_after_conversation: 'false'
combat_delay: '5'
notify_pullback: 'true'
default_package: default
remove_items_after_respawn: 'false'
quest_items_unbreakable: 'true'
sounds:
  start: ENTITY_VILLAGER_AMBIENT
  end: ENTITY_VILLAGER_YES
  journal: ENTITY_BAT_TAKEOFF
  update: 'false'
  full: 'false'
cmd_blacklist:
- spawn
- home
- warp
- mobarena
- ma
- tpa
- tpaccept
- tpyes
- suicide
- f home
- pvp
hook:
  citizens: 'true'
  mythicmobs: 'true'
  vault: 'true'
  worldguard: 'true'
  skript: 'true'
  mcmmo: 'true'
  effectlib: 'true'
  playerpoints: 'true'
  heroes: 'true'
  magic: 'true'
  denizen: 'true'
  skillapi: 'true'
  quests: 'true'
  shopkeepers: 'true'
  placeholderapi: 'true'
  holographicdisplays: 'true'
  racesandclasses: 'true'
  legendquest: 'true'
  worldedit: 'true'
journal:
  chars_per_page: '245'
  one_entry_per_page: 'false'
  reversed_order: 'true'
  hide_date: 'false'
  full_main_page: 'false'
journal_colors:
  date:
    day: '9'
    hour: '6'
  line: '4'
  text: '0'
conversation_colors:
  npc: dark_red
  player: dark_green
  text: green,italic
  answer: gray
  number: yellow
  option: aqua
date_format: dd.MM.yyyy HH:mm
effectlib_npc_effect:
  class: VortexEffect
  iterations: 20
  particle: crit_magic
  helixes: 3
  circles: 1
  grow: 0.1
  radius: 0.5
  delay: 5
debug: 'false'

[Momonche]

Some news about that ?

[joblo2213]

It took me quite a long time to figure out what is causing this:

BetonQuest is adding the color codes to every word to keep the color after a line wrap. This results in every word having way more characters than those who are actually displayed and wrapping each line before it acutally should.
I'm currently working on a fix and will create a pull request then.

[MWFIAE]

Don't forget, that ressourcepacks can change the font and therefore how many characters fit on one line...
I hate the text stuff in mc^^

[joblo2213]

This wont be a issue here as the only limit for the length of item hover texts is your screen size.
BetonQuest has it's cap at a maximum of 42 characters per line.
Depending on the resourcepack the hover text will be bigger or smaller but nothing will get cut off here.

I'm always using a resourcepack with custom font and for books this can cause huge pain.
So we can create a self help group (no idea if this is propper english or if I'm now sitting in one boat with mr. Oettinger) 😉

[MWFIAE]

Oh yeah books... I'm not sure what we tried but it was a disaster....

Oh and I had an issue with the textlength in hover chatcomponents too... It crashed the connection to the client^^

I don't know the proper english way to say it either^^ But yeah a self help Group would be nice x'D

[Momonche]

Some news about that ?

[joblo2213]

Look at the cross referenced PR (#775). It is fixed there.

You could compile a dev build yourself from there or wait till @Co0sh is able to merge it.

[Blamo27]

@joblo2213 Do you have a CI ? It would be better to auto compile the dev branch in a Jenkins or else

[Blamo27]

@joblo2213 There is a travis, you can't build the jar with it ?

[Co0sh]

@joblo2213 you can merge PRs yourself, I have no problem with that. Just let me know if you need help with anything :)

[joblo2213]

@Co0sh Ok I'm in hollidays currently but I'll do so once I'm back at home again.
If this is fine for you I'dd work on the main branch in future. :+1:

One thing I have recognized is that the documentation pdfs for dev builds are not automatically generated from the docs directory.
If you could add that it would be awesome.

@Blamo27 Travis will automatically build and upload a jar to betonquest.pl once the PR is merged.
You could use maven to compile the source code to a jar but I don't think its a good idea to share unofficial dev builds which aren't listed on betoncraft.pl

[Co0sh]

Yeah, I need to do that :D

[Blamo27]

@joblo2213 A lot of plugins that are created in spigot, build and compile dev branch even if it's not a good idea, it is really useful for users

[Co0sh]

@Blamo27 Anyone can put any code in a pull request, so compiling it automatically is a really bad idea, we're not going to do that.

[joblo2213]

@Blamo27 As I wrote before betonquest does that too for al code in the betonquest repo. But while this branch isn't mergerd it is only a change in my private fork of betonquest.
It's just not a good idea if I now start sharing my own private dev builds which aren't listed under betonquests dev builds and don't follow the propper versioning.

As written above with Co0sh I'll do all future changes directly in this repo so that then dev builds will be created directly.

[joblo2213]

Merged the PR. Have a look at dev build #362.