Bentobox: Poor performance

[cloakfox]

Using BentoBox 1.15.1 on Paper 1.16.4
With main addon being AOneBlock 1.4.5

Noticed tps was dropping with 40/50+ players so grabbed a spark sampler and then noticed bentobox is the culprit.

https://spark.lucko.me/#hShcJsIg5E

Thanks in advance for taking a look.

[tastybento]

It looks like it is the updateInventory() call that is causing this:

This call is deprecated, but as the JavaDocs say there is no alternative.

This call is made to update the player's inventory when they illegally pick up items that they should not. In the report, it looks like the item pickup is being rejected. I'll see if there's a way to optimize this so that it doesn't get called unless it is required.

[tastybento]

This change should help. I'd be interested to see if it does.

[cloakfox]

This change should help. I'd be interested to see if it does.

Thanks! I will get back to you after the weekend (when I have meaningful timings/sparks)

[cloakfox]

New spark sampler, still is some impact I think, but not 100% sure.
https://spark.lucko.me/#sVYW315gA9

[tastybento]

Looks clean to me.

[cloakfox]

Awesome, well thanks for the help :D