Bentobox: AcidIsland - Purge broken

[ScuroK]

Description

Describe the bug

hi there. i have a question about acidisland
it seems like /acid purge is broken. when i used it last time it deleted all of the islands. when i use /acid purge 100 it tells me there are 58 abandoned islands. And when i use /acid purge 2000 it still shows 44 inactive islands. but whe just recently added acid. so im sure this values are wrong
any chance you could help me

Steps to reproduce the behavior

Use the acid purge command.

Expected behavior

it should only delete inactive islands regarding the number of days i choose

Environment

BentoBox Version (Mandatory)

Running PAPER 1.15.2.
BentoBox version: 1.12.0
Database: JSON
Loaded Game Worlds:
acidisland (AcidIsland): Overworld, [nether_color]Nether, [end_color]End
Loaded Addons:
AcidIsland 1.12.0 (ENABLED)
Biomes 1.7.0 (ENABLED)
Challenges 0.8.0 (ENABLED)
Greenhouses 1.0.0 (ENABLED)
Level 1.9.3 (ENABLED)
Limits 1.9.4 (ENABLED)
Warps 1.9.0 (ENABLED)

[Poslovitch]

Please provide the actual /bbox v output, there is no "1.12.2" version for BentoBox.

[tastybento]

Please run /bbox v and copy and paste the output.

Let me clarify:

when i used it last time it deleted all of the islands.

Okay, so you used the purge and it deleted all the islands?

when i use /acid purge 100 it tells me there are 58 abandoned islands.

So, after it deleted all the islands, you ran the command again and are are told that there are 58 abandoned island?

And when i use /acid purge 2000 it still shows 44 inactive islands.

Ok. It sounds like it's decreasing.

but whe just recently added acid. so im sure this values are wrong

Hmm. Yes weird.

Island deletion is done very slowly and so there could be islands in the database still being deleted over time. Do you see anything in /plugins/BentoBox/database/IslandDeletion? I assume you're using JSON database.

[ScuroK]

@tastybento
No. After the mistake happened for the first time, I restored all bentobox and acid files aswell as the world folders from backup. Thats why i dont have any infos on deleted files. The recent values are from /acid purge but without actually running the purge using the confirm command.

[ScuroK]

Running PAPER 1.15.2.
BentoBox version: 1.12.0
Database: JSON
Loaded Game Worlds:
acidisland (AcidIsland): Overworld, [nether_color]Nether, [end_color]End
Loaded Addons:
AcidIsland 1.12.0 (ENABLED)
Biomes 1.7.0 (ENABLED)
Challenges 0.8.0 (ENABLED)
Greenhouses 1.0.0 (ENABLED)
Level 1.9.3 (ENABLED)
Limits 1.9.4 (ENABLED)
Warps 1.9.0 (ENABLED)

[ScuroK]

Could it be because i use high values like 100 days which are higher than the time i run acidisland and bentobox on my server?

Im not sure how long exactly i have it. But not long.

[tastybento]

Please share the following files (in a zip):

usercache.json (this is from your server folder)
a zip of the /plugins/BentoBox folder.

I'll try and replicate.

[ScuroK]

I send you the files on discord. Its tar files hope thats ok

[tastybento]

Found the bug. Looks like an overflow issue.

[ScuroK]

means? :D fixable?

[tastybento]

Yes, fixed now. Pushing...

[tastybento]

Wait for Jenkins to finish building and then test the snapshot and see how it works for you.

[tastybento]

Okay done: https://ci.codemc.io/job/BentoBoxWorld/job/BentoBox/1771/

[ScuroK]

awesome! thank you so much! gonna try it tmr :)