Bentobox: ConcurrentModificationException on SaveAll task

[NotMyFault]

Description

Describe the bug

ConcurrentModificationException on SaveAll task

Steps to reproduce the behavior

Idk, it just appeared

Screenshots and videos

Let's just pastebin the exception http://haste.athion.net/valapijave.rb

Expected behavior

No exception

Environment

Server

• OS: Linux 3.10.0-693.11.6.el7.x86_64
• Java version: OpenJDK 64-Bit Server VM 25.212-b01

Plugins

AJAntiSpam, AJNickname, AJRankFix*, AntiAFK*, BentoBox, BuycraftX, CasinoSlots*, ChatLog*, ChatReaction, ChestCommands, ChestShop, ClearChat*, ClearLag, CommunityChest*, ConsoleSpamFix, CrateReloaded, CrazyAuctions, CustomEnderChest, CustomJoinMessagesPlus*, CustomList*, DeluxeChat, DeluxeMenus, DiscordLink*, DonorBroadcast*, EditableSign, EpicRename, Essentials, EssentialsChat, EssentialsSpawn, EZBlocks*, FeatherBoard*, HeadDatabase*, HolographicDisplays, IllegalStack, Item2Chat, LiquidTanks*, Lottery, LuckPerms, mcMMO, MegaRestart*, MessageAnnouncer, MineableSpawners, MorphTool, MsgColor*, Multiverse-Core, MVdWPlaceholderAPI*, OpenInv*, PacketListenerApi*, PartyAndFriendsGUI, PlaceholderAPI*, PluginHiderPlus, PlugMan, ProtocolLib, ProtocolSupport, ShopGUIPlus, SignSpy*, StackMob, Status-for-Party-and-Friends*, TAB, Teleport-To-Friend-PAF-Extension*, TimeVote, TitleAPI, TradeSystem, Vault, VoidGenerator, VoidSpawn, VoteRoulette*, Votifier, Vouchers*, WeatherVote, WorldEdit, WorldGuard, WorldGuardExtraFlags

BentoBox setup

BentoBox and Addons

Configuration

MariaDB

Additional context

@Poslovitch led me here, as this appears to be a critical issue.
It makes my logs ridiculous large with the spam

[tastybento]

@N0tMyFaultOG can you look in your database and see if there is an island in the islands table with a null uniqueId?

[NotMyFault]

@tastybento

[tastybento]

I just pushed two changes. Let them compile on the CI and then please have a look to see if that stops the error. How often do you save the database in BentoBox's config.yml? Default is every 5 minutes, so if that's true it may take 5 minutes or more before you see hopefully nothing.

By the way, this error is not damaging. It's just a backup way of saving the databases and failing midway should not be an issue. One issue I have is with testing. I need to build some test harnesses so I can test large datasets.

[NotMyFault]

Good to hear, my backup-period is set to 5, I did not touch it. I'll give the builds a try and report the status back.

[NotMyFault]

I did not encourage the cme within the past hours, thanks for the fix 👍