Bentobox: Island members receive random Protected Island messages for their own island

[wellnesscookie]

Description
We have got a few complains that players receive Island Protected messages for their own island. It's not only members and co-owners, but owners too. So we can exclude the posibility that the owner is messing with island settings at the moment when these messages pop up.

Steps to reproduce the behavior:
- We gave our best to determine how to reproduce this, but we only came with next:
1. Owner & Members interact with blocks. Mostly happened when they were placing dirt, right clicking it with Hoe tools and planting seeds.
2. Container access message pop-up: https://prnt.sc/mivmoe
3. Trapdoor usage message pop-up log (These ones spam more than once while working with dirt):
[17:36:42] [main/INFO]: [CHAT] Zaštićeno ostrvo: Zabranjeno korišćenje trapdoor-a
4. Hopper interaction message pop-up ss: http://prntscr.com/mj75si
5. We have seen messages popping up for button, beacon, redstone flags and a few more.

Expected behavior
Island Members shouldn't receive these messages if they are whitelisted on them-related flags, while owners should never.

Server Information:

• Database being used:
  MySQL
• OS:
  Debian GNU/Linux 9
• Java Version:
  Java(TM) SE Runtime Environment 18.3 (build 10.0.1+10)
  Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.1+10, mixed mode)

[13:32:32] [main/INFO]: [CHAT] Running PAPER 1.13.2.
[13:32:32] [main/INFO]: [CHAT] BentoBox version: 1.3.0-SNAPSHOT
[13:32:32] [main/INFO]: [CHAT] Loaded Game Worlds:
[13:32:32] [main/INFO]: [CHAT] skyblock (skyblock)
[13:32:32] [main/INFO]: [CHAT] Loaded Add-Ons
[13:32:32] [main/INFO]: [CHAT] BSkyBlock 1.3.0-SNAPSHOT
[13:32:32] [main/INFO]: [CHAT] WelcomeWarps 1.2-SNAPSHOT
[13:32:32] [main/INFO]: [CHAT] Challenges 0.3.1-SNAPSHOT
[13:32:32] [main/INFO]: [CHAT] Level 1.2.1-SNAPSHOT
[13:32:32] [main/INFO]: [CHAT] Biomes 0.5.0-SNAPSHOT
[13:32:32] [main/INFO]: [CHAT] SerbCraftAddon 2.0

• Other plugins?
  
  
  
  • [06:32:17 INFO]: Plugins (50): AnimatedNames, AreaShop, ArmorStandTools, BentoBox, BungeeTabListPlus, ChatControl, ChestCommands, ChestShop, ClearLag, CrateReloaded, EditableSign, Essentials, EssentialsChat, EssentialsSpawn, ExecuteEverywhere, FastAsyncWorldEdit, FeatherBoard, HeadDatabase, HolographicDisplays, HungerKeeperPlus, IPWhitelist, IslandBorder, LeaderHeads, LibsDisguises, LuckPerms, MobManager, Multiverse-Core, MVdWPlaceholderAPI, NickRemover, NoSleepCMDs, OpenInv, PlayerHeads, PlayerPoints, ProtocolLib, PvPManager, PvPManagerBossBar, RedstoneClockDetector, RPGHealthIndicator, SilkSpawners, SkinsRestorer, Spartan, TradeMe, TrophyHeads, UnbreakingAnvils, Vault, VoidGenerator, WorldEdit, WorldGuard, WorldGuardPistonFix, Yamler
  
  

Additional context
None for now. We will give our best in the meantime to help and find out how to exactly reproduce this problem if there are any and considering it's not random.

[Poslovitch]

Wow, definitely sounds weird.
By the way, could you please update your locales and redo the /bbox v output?

[wellnesscookie]

Confirmed from another case:
When transforming Coarse Dirt > Dirt with Hoe tool, the problem above occurs.

• Player complained
• I asked him if he had been doing anything with dirt, and he replied just as the 1st, he was transforming COARSE_DIRT > DIRT
• We are still not sure for placing and planting.

EDIT: We will give you a new output in the meantime.
EDIT v.2: Locales updated! :)

[tastybento]

Run the admin why command on the players to see why they are being blocked. Capture the log and share it.

>bsbadmin why LSPvicky
[12:18:30 INFO]: Turning on console debug for LSPvicky.
[12:18:38 INFO]: [BentoBox] Why: BlockPlaceEvent in world AcidIsland_world at 129,54,127
[12:18:38 INFO]: [BentoBox] Why: LSPvicky PLACE_BLOCKS - RANK_ALLOWED

[wellnesscookie]

@tastybento
Both owner and member were being debugged, though caught owner this time!
There you go> https://pastebin.com/CBmwSCKQ

When it popped up, I stopped debugging.
[21:50:08] [Server thread/INFO]: [BentoBox] Why: Santana CONTAINER - NOT_ALLOWED_ON_ISLAND
Santana is the owner: http://prntscr.com/mja9a7

By the time, we have also seen BrewingStand flag popping up too. Though we only have a screenshot of it.

[tastybento]

I fixed a bug with 5beeb97f995a5c8adf112a1295a5a6b99f6c5d1d that is likely related to this.

[tastybento]

@wellnesscookie It'd be good to try the latest build and see if you can still replicate the issue.

[wellnesscookie]

@tastybento
Umm, I will need you to tell me again if we should.

Poslovitch wrote (https://github.com/BentoBoxWorld/BentoBox/commit/5beeb97f995a5c8adf112a1295a5a6b99f6c5d1d#r32265192):

Read the comment there. I'm afraid this commit is a regression.

[tastybento]

@wellnesscookie Okay, please try it now. It should work.

[wellnesscookie]

Sorry for late reply, but we updated right now.
I will let you know if it happens again.

[wellnesscookie]

None complains by now, seems fixed.