Bentobox: Gamemode 3 bugs

[Kryniowesegryderiusz]

Description
I have two more bugs that occured with gm3:

• One player tried to add another one and every time it gaved him gm3 after joining island
• Some players after teleporting to end are getting gm 3

[Please complete the following information:]

• Database being used: MySQL
• OS: Linux
• Java Version: java 11

19.01 02:00:26 [Server] INFO Bentobox version: 1.1-SNAPSHOT
19.01 02:00:26 [Server] INFO Loaded Game Worlds:
19.01 02:00:26 [Server] INFO SkyBlock (SkyBlock)
19.01 02:00:26 [Server] INFO Loaded Add-Ons
19.01 02:00:26 [Server] INFO BSkyBlock 1.1-SNAPSHOT
19.01 02:00:26 [Server] INFO Challenges 0.3.1-SNAPSHOT
19.01 02:00:26 [Server] INFO Biomes 0.4.0
19.01 02:00:26 [Server] INFO WelcomeWarps 0.1.0-SNAPSHOT
19.01 02:00:26 [Server] INFO Level 1.1-SNAPSHOT

[tastybento]

Do the players get put into Spectator and then just sit there, or do they teleport somewhere and then remain in Spectator?

[Poslovitch]

Partially duplicate of https://github.com/BentoBoxWorld/BentoBox/issues/377

[Kryniowesegryderiusz]

They teleport to end / someones island and them get spectator.

[lukeeexd]

Had this happen too. Guy accepted team invite and it made him spectator on the island. I had to manually change the gamemode. This error is what showed after he accepted the invite

[16:30:24 WARN]: [BentoBox] Task #133958 for BentoBox v1.1 generated an exception
        at world.bentobox.bentobox.managers.IslandsManager.deleteIsland(IslandsManager.java:254) ~[?:?]
        at world.bentobox.bentobox.api.commands.island.team.IslandTeamInviteAcceptCommand.lambda$execute$1(IslandTeamInviteAcceptCommand.java:99) ~[?:?]
        at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:82) ~[patched_1.13.2.jar:git-Paper-503]
        at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:449) ~[patched_1.13.2.jar:git-Paper-503]
        at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1003) ~[patched_1.13.2.jar:git-Paper-503]
        at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) ~[patched_1.13.2.jar:git-Paper-503]
        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:938) ~[patched_1.13.2.jar:git-Paper-503]
        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:836) ~[patched_1.13.2.jar:git-Paper-503]

[Poslovitch]

Thanks for the stacktrace @lukeeexd

[Poslovitch]

@Kryniowesegryderiusz Can you try to download 1.2.0 devbuilds from the CI and tell us if the following still happens?

One player tried to add another one and every time it gaved him gm3 after joining island

In regards to the second occurence, I'll manage it on #377 instead.

[Kryniowesegryderiusz]

Its hard to say, because it occurs randomly :/ And only sometimes

[Poslovitch]

Okay, I'll consider this bug as fixed. Reopen the ticket with a stacktrace if it still happens.

[lukeeexd]

https://streamable.com/4lh16 Shows how it happens. If you have an island and accept an invite it works fine if you dont have an invite and accept an invite you get put into spectator and dont get the on-accept team message