Do you think it makes sense to swap the current getting started guide 1 and 2. It seems that the package should be installed into the console application.
@steveoh you are right, the doc should mention creating a console app before installing the NuGet package
would you be interested in sending a PR? the file is here: https://github.com/dotnet/BenchmarkDotNet/blob/master/docs/articles/guides/getting-started.md
I tried to send PR but I'm not sure if i did it correctly. It's my first PR ever.
Hi @michalgalecki
Thank you for your help!
You have opened the PR against your fork, while you should have opened it against the upstream repo (https://github.com/dotnet/BenchmarkDotNet in our case)
When you want to send a PR, you should push changes to a branch of your fork (you have done that) and after you do it, when you go to the upstream repo page you should see a new green button "Compare & Pull Request" like this:

This magic button is visible only for some time after you push the changes so you won't see it now unless you push something to your branch again.
Since the magic button is gone, you need to do the following:
Go to https://github.com/michalgalecki/BenchmarkDotNet/pulls and click "New Pull Request" button:

Chose the branch of your fork:

and press the "Create Pull Request" button.
Right, I thought that something went wrong. Now PR should be fine.
Thanks for the guide!
Most helpful comment
Right, I thought that something went wrong. Now PR should be fine.
Thanks for the guide!