The setup attributes were renamed to [GlobalSetup]/[GlobalCleanup] recently.
I think there is no need to introduce Global prefix, old names are fine. Most of unit test frameworks do use same names for similar attributes and therefore old names were self-explanatory. In code it looks fine, too:
```c#
[Setup]
public void Setup() { ... }
[IterationSetup]
public void SetupIteration() { ... }
```
As additional proposal (have no good arguments for it, though). If the Setup/Cleanup will be renamed back, the IterationSetup attribute may be renamed to SetupIteration, this way it will be easier to discover a new attribute via code completion
Hey @ig-sinicyn, thanks for your feedback. I want to keep [GlobalSetup]/[GlobalCleanup] because of the following reason:
[Setup] really means? A lot of people think that the setup method will be invoked before each benchmark target method invocation so such name can be confused. I hope that it will be obvious for people (especially for new users) that [GlobalSetup] is, you know, a global setup.[Setup], [SetupIteration] names, it will be easy to find all the code related to [SetupIteration], but it will be hard to find code related to [Setup] but not [SetupIteration]. With [GlobalSetup], we don't have such problem.@adamsitnik what do you think?
@AndreyAkinshin well, I see your point now and it looks better than mine:)
I agree, @AndreyAkinshin has very good arguments. I was asked how often is [Setup] invoked so many times that I hope that now it will change.
Most helpful comment
Hey @ig-sinicyn, thanks for your feedback. I want to keep
[GlobalSetup]/[GlobalCleanup]because of the following reason:[Setup]really means? A lot of people think that the setup method will be invoked before each benchmark target method invocation so such name can be confused. I hope that it will be obvious for people (especially for new users) that[GlobalSetup]is, you know, a global setup.[Setup],[SetupIteration]names, it will be easy to find all the code related to[SetupIteration], but it will be hard to find code related to[Setup]but not[SetupIteration]. With[GlobalSetup], we don't have such problem.@adamsitnik what do you think?