Barrier: Additional mouse button support
Operating Systems
Server: Fedora 28
Client: Windows 10 Build 1803
Barrier Version
2.1.0
Steps to reproduce bug
- Use a mouse that has additional buttons (i.e forward and back buttons)
- Try and use those buttons while in the client
Other info
It would be nice if at least the forward and back buttons would work.
rmb938
All 9 comments
I got forward&back buttons working along with horizontal scroll some time ago. Works on X11 & Win32 but I never tested on OSX.
main patch:
- https://github.com/yupi2/synergy/commit/b2a0ab2f58038a7b20f6e792711f33a778053350
- https://github.com/yupi2/synergy/commit/b2a0ab2f58038a7b20f6e792711f33a778053350.patch
later patch to suppress warning:
- https://github.com/yupi2/synergy/commit/4541a799e07b8411f95d275005a485e10ce2143c#diff-a32b85f634235bfc6c47ee4b259d4175R700
If/when someone applies the patch remember to include my author information for git.
yupi2
on 28 May 2018
Can someone make a PR for this please?
walker0643
on 30 Jun 2018
Inactive for over 2 months. Closing (but would still like to have the PR!)
walker0643
on 9 Sep 2018
Inactive for over 2 months. Closing (but would still like to have the PR!)
What's the most effective way to get this patch integrated? I'd really like to use my back and forward buttons without maintaining an entire copy of this. :+1:
aaronsb
on 13 Dec 2018
Hi, here's a patch with yupi2's changes modified to apply correctly to barrier.
https://github.com/vorph1/barrier/commit/5111f402d0d3c7fa3e085696ef146d19b154e6dc
Back/forward buttons and horizontal scroll work but there's some instability. I'm not sure if that's from the patch or the master branch is unstable itself as I only applied to head and not any stable releases.
Tested only linux server and win10 client so far.
vorph1
on 24 Jan 2019
I've now confirmed that the instability is not present with the patch applied to 2.1.2.
I might find time to set up a macos instance to test but no promises there.
Would you consider merging the patch as is or do you need any changes? Also I'm not sure where would be the best place to mention it's yupi2's contribution so any feedback welcome there.
vorph1
on 25 Jan 2019
Would just need to create a PR. I could do it and then we could review the code.
AdrianKoshka
on 25 Jan 2019
Would just need to create a PR. I could do it and then we could review the code.
Has a PR been created yet?
aaronsb
on 31 May 2019
Yes, #242
AdrianKoshka
on 31 May 2019
Related issues
mandusm
路
34Comments
WreckWren
路
18Comments
TafThorne
路
21Comments
AdrianKoshka
路
22Comments
jwulf
路
18Comments
Most helpful comment
Hi, here's a patch with yupi2's changes modified to apply correctly to barrier.
https://github.com/vorph1/barrier/commit/5111f402d0d3c7fa3e085696ef146d19b154e6dc
Back/forward buttons and horizontal scroll work but there's some instability. I'm not sure if that's from the patch or the master branch is unstable itself as I only applied to head and not any stable releases.
Tested only linux server and win10 client so far.