Azuredatastudio: Intellisense delayed

[yualan]

• Azure Data Studio Version: 1.3.9

Steps to Reproduce:

1. Download latest version of Azure Data Studio (1.3.9)
2. Connect to localhost SQL Server 2017
3. Open New Query Window
4. Type S
5. Intellisense has a clear delay

I have tried a fresh install and restarting computer, and refreshing intellisense cache. Computer is 16gb and 4 cores.

[anthonydresser]

We haven't made any changes in this area in a while that I know of. @kburtram is it possible that it was caused by https://github.com/Microsoft/sqltoolsservice/commit/0fd98df79b27a25a23dcc3dea98dd1999144661d

[yualan]

This was also repro-ed by @chlafreniere and appears to be affecting T-SQL notebooks. Thanks Anthony and Karl for investigating

[kburtram]

@anthonydresser this is not likely related to Microsoft/sqltoolsservice@0fd98df which bumps from a near-RTM preview of SqlClient to the RTM SqlClient. IntelliSense is handled by SMO, SQL Parser, and logic in SQL Tools Service, so any minor changes in SqlClient between those two versions is unlikely to impact IntelliSense perf. Most likely this is related to the issue we've always had populated the SMO MetadataProvider cache.

[vickyharp]

I'm experiencing this with snippet intellisense.

In this clip I am trying to use a snippet called vh_where.

2.33 sec: I finish typing vh_ and pause to autofill
3.13 sec: red squiggles appear
5.75 sec: user snippet hint appears

Here's another on a new query window that is entirely disconnected.

2.54 sec: I finish typing vh_where (the full snippet name)
5.67 sec: user snippet hint appears

This is vscode with the exact same sql.json user snippet file.

1.25 sec: I type v
1.29 sec: user snippet hint appears

[yualan]

We might need to do additional investigation on this issue since this is happening on Vicky's machine as well. I'll try the insider build

[kevcunnane]

This is a bug due to notebook support. Fixing and verifying now.

[yualan]

Thanks Kevin!