Azure-docs: registerMessageHandler @Deprecated

[spottedmahn]

The example is currently using the 1st method which is @Deprecated. Looks like it should be switched over to the 2nd method? 🤔 What's an ExecutorService though?

@Deprecated
@Override
public void registerMessageHandler(IMessageHandler handler, MessageHandlerOptions handlerOptions) throws InterruptedException, ServiceBusException {
    this.messageAndSessionPump.registerMessageHandler(handler, handlerOptions);
}

@Override
public void registerMessageHandler(IMessageHandler handler, MessageHandlerOptions handlerOptions, ExecutorService executorService) throws InterruptedException, ServiceBusException {
    this.messageAndSessionPump.registerMessageHandler(handler, handlerOptions, executorService);
}

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: 8dd3492a-d52b-d231-d647-cb73328c9df1
• Version Independent ID: e5d3d05f-1c8c-22f4-288d-6642288dbd4e
• Content: Use Azure Service Bus topics and subscriptions with Java
• Content Source: articles/service-bus-messaging/service-bus-java-how-to-use-topics-subscriptions.md
• Service: service-bus-messaging
• GitHub Login: @axisc
• Microsoft Alias: aschhab

[mike-urnun-msft]

@spottedmahn Thank you for your feedback! We will review and update as appropriate.

[mike-urnun-msft]

@spottedmahn This doesn't appear to be the case per: https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/microsoft-azure-servicebus/src/main/java/com/microsoft/azure/servicebus/MessageHandlerOptions.java

We will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

[spottedmahn]

registerMessageHandler isn't in the source file you referenced, 🤔

I believe this is the correct source code, SubscriptionClient.registerMessageHandler, referenced in the sample.

[spottedmahn]

Hi @mike-urnun-msft - can you re-review and re-open this? thanks! 🙏

registerMessageHandler isn't in the source file you referenced, 🤔

[mike-urnun-msft]

@spottedmahn checking... will update you shortly ;)

[kensonwu1]

Hi team,
How is the state of this issue, any update?
Could you also update the example as well: https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-java-how-to-use-topics-subscriptions#how-to-receive-messages-from-a-subscription
Thanks.

[PramodValavala-MSFT]

@spottedmahn @kensonwu1 The ExecutorService class used here is the java.util.concurrent.ExecutorService class used for asynchronous concurrent execution.

I believe the intent of the new methods is to expose this as a parameter for customization but you could simply pass ForkJoinPool.commonPool() used in the deprecated method to care of the lint error or use another built-in executor.

For example, if you would want to ensure messages are processing sequentially, you could use Executers.newSingleThreadExecuter.

Hope that information helps, and we are assigning this issue to include samples for the same in the docs.

[spottedmahn]

thanks for reviewing @PramodValavala-MSFT 👍

[spelluru]

in-progress

[spelluru]

Updated the code.

please-close