Azerothcore-wotlk: All Daily Profession Quest stopped working

[Ashland]

All Daily Profession Quest stopped working

SMALL DESCRIPTION:

Daily Profession Quest stopped working go to cooking trainer or fishing trainer and try to get daily quest in dalaran

EXPECTED BLIZZLIKE BEHAVIOUR:

Fishing trainer https://wotlk.evowow.com/?npc=28742#starts should give one of 5 quests

CURRENT BEHAVIOUR:

giving no dailies at all for fishing , same for cooking and other professions

STEPS TO REPRODUCE THE PROBLEM:

max fishing skill and try to get daily from https://wotlk.evowow.com/?npc=28742#starts

EXTRA NOTES:

same with cooking , max cooking skill and try to get daily from npc 29631 Awilo Lon'gomba

BRANCH(ES):

master

AC HASH/COMMIT:

AzerothCore rev. f9a8de9be767+ 2019-11-15 16:31:54 +0700 (master branch) (Unix, Release)

OPERATING SYSTEM:

Debian /10

MODULES:

mod-cfbg
mod-indivdual-xp
mod-1v1-arena

OTHER CUSTOMIZATIONS:

no

[FrancescoBorzi]

@wowpide after which commit did they stop working?

[Zausender]

Confirmed. Before merging PR's you need the testers there. Not the people who will merge on their core your PR and just say "TESTED, Builded without errors no problems" What's tested actually so they can confirm it's really tested, the errors won't show alone instantly on build. And that sucks. I just checked some last PR's merged on master, they re merged with confirmation on the comments that i mention already "TESTED, Builded without errors no problems".
We can't know which commit break it, you should ask the people who Merged latest commits

[FrancescoBorzi]

@Zausender I agree with you, we should test things more deeply as our application is quite complex and it doesn't have any kind of automated tests in place. I hope more people can help with it.

About this issue specifically, can you please let us know which commit is causing the issue? so we can fix or revert it.

[sluggor]

This NPC (28742 - Marcia Chase / Grand Master Fishing Trainer & Supplies) is the quest starter for the Dalaran fishing quests 13830, 13832, 13833, 13834, and 13836. These quests are in pool 5676.

There was a change to the pool manager code a few months ago (#2027) that may be worth a look.

If your last pull was more than a few months ago, you could try reverting that code and see what happens.

Other than #2027, I don't remember seeing any recent issues that dealt with Dalaran NPCs or daily quests.

[ghost]

Tested with commit b1e5943e0aa8a23fea7ed9a3d763830adb778e61 and a fresh DB and I cannot confirm this issue. Could get a new daily fishing quest from Marcia Balzer and a new daily cooking quest from Awilo Lon'gomba.

[FrancescoBorzi]

@wowpide @Zausender please help us reproduce the issue on a clean (latest) AC, otherwise we are not able to fix it

[pklloveyou]

The players in my server did not report this error and the server ran for two months

[Ashland]

@pkiloveyou this started in the last week so you can’t if tested tgat this doesn’t work in the last 2 months .
@stoabroagga I guess we get no help even though 2 confirmed cases , spewing not very good support here , just say it’s fine after confirmation I guess I try TrinityCore

[Ashland]

@Zausender you have Linux too and Maria ? This started they are working here https://github.com/azerothcore/azerothcore-wotlk/commit/c294dd3142b10ab822982cda02728818c11f72da on this commit if I go back but I loose the crash fix’s

[ghost]

I'm using Ubuntu 16.04 x64, cmake 3.15.5, clang 7.1.0, MySQL 5.7. And @wowpide this is a hobby project, you don't pay for it and we don't get paid, so instead of just complaining you could also contribute by helping to nail down the errors. We can only fix errors that we can reproduce.

[Ashland]

@Zausender did reproduce . I should no better than to make issue , can delete if you want no help here no one gets paid so they don’t help such a shame

[Ashland]

I guess only help me if I’m rich and have money to buy fix

[ghost]

Even money cannot help you here as there's too few information to work with.

[Yehonal]

I remember a similar issue happened suddenly on a live server, but I don't remember what caused it, fixed with a simple restart if I remember well. Could be an edge case but ofc we should investigate more next time

[Ashland]

Thank you @Yehonal