Azerothcore-wotlk: Crash - Exploit hacker

[Mestremagos]

Hello friends
I've been suffering attacks for 2 months

First attack was with macro / rum - Fixed
Second with program AccLeiTo-Crash - Fixed

Now I have a new problem with our log and I have no idea.
https://pastebin.com/bJidXUwC <<<<<
Operation System *
Windows Server 2012 Server 4.0 (Version 6.2, Build 9200)

If anyone has an idea, it would help me a lot

[Helias]

hope this can help https://github.com/azerothcore/azerothcore-wotlk/pull/2410
try to add this PR Into your server and give us any feedback (positive or negative)

[Mestremagos]

Vou apply and await face attack on return,
Thank you so much for trying to help me.

[Mestremagos]

Server was attacked and crashed 25x
Unfortunately it didn't solve.
Same crash log error as above

[BarbzYHOOL]

First attack was with macro / rum - Fixed

how was it fixed?

[Mestremagos]

/run function CrashServer() SendChatMessage("\124cffffd000\124Henchant:59387\124h[Inscription]\124h\124r", "SAY") end CrashServer()
fix

WorldSocket.cpp

-catch (ByteBufferException &)

+catch (ByteBufferException const&)

ChatLink.cpp

_iss >> commandChar;
_iss.get(commandChar);
Vehicle.cpp

+//events are executed in the game same update
+if (Passenger->GetVehicle())
+Passenger->ExitVehicle();

O primeiro ataque foi com macro / rum - Corrigido

como foi consertado?

[avatar789]

/run function CrashServer() SendChatMessage("\124cffffd000\124Henchant:59387\124h[Inscription]\124h\124r", "SAY") end CrashServer()
fix

WorldSocket.cpp

-catch (ByteBufferException &)

+catch (ByteBufferException const&)

ChatLink.cpp

_iss >> commandChar;
_iss.get(commandChar);
Vehicle.cpp

+//events are executed in the game same update
+if (Passenger->GetVehicle())
+Passenger->ExitVehicle();

O primeiro ataque foi com macro / rum - Corrigido

como foi consertado?

hese changes do not fix macro crashes

[Shard-MW]

/run function CrashServer() SendChatMessage("\124cffffd000\124Henchant:59387\124h[Inscription]\124h\124r", "SAY") end CrashServer()
fix

WorldSocket.cpp

-catch (ByteBufferException &)

+catch (ByteBufferException const&)

ChatLink.cpp

_iss >> commandChar;
_iss.get(commandChar);
Vehicle.cpp

+//events are executed in the game same update
+if (Passenger->GetVehicle())
+Passenger->ExitVehicle();

O primeiro ataque foi com macro / rum - Corrigido

como foi consertado?

@BarbzYHOOL
Can't reproduce it even without the fix ^^'

[BarbzYHOOL]

apparently they're nto on azerothcore

[Helias]

I've just added these checks in this PR https://github.com/azerothcore/azerothcore-wotlk/pull/2410
But I really didn't understand where should I add

+//events are executed in the game same update
+if (Passenger->GetVehicle())
+Passenger->ExitVehicle();

[LichKing255]

/run function CrashServer() SendChatMessage("\124cffffd000\124Henchant:59387\124h[Inscription]\124h\124r", "SAY") end CrashServer()
fix

WorldSocket.cpp

-catch (ByteBufferException &)

+catch (ByteBufferException const&)

ChatLink.cpp

_iss >> commandChar;
_iss.get(commandChar);
Vehicle.cpp

+//events are executed in the game same update
+if (Passenger->GetVehicle())
+Passenger->ExitVehicle();

O primeiro ataque foi com macro / rum - Corrigido

como foi consertado?

this edits not fix this macro. i tested edits except vehicle, and i don't think relation with vehicle.

[Helias]

I really don't trust that edits, but they make more "strict" the immutability of the code, so I think that we can add them.

[Helias]

I updated this: https://github.com/azerothcore/azerothcore-wotlk/pull/2410
test it and give me feedback pls

[Helias]

Hope this can help https://github.com/azerothcore/azerothcore-wotlk/pull/2410
I finished the PR, test it ;-)

[Mestremagos]

So far without dc

[Helias]

The crash still persist when I use the following command in game:
/run function CrashServer() SendChatMessage("\124cffffd000\124Henchant:59387\124h[Inscription]\124h\124r", "SAY") end CrashServer()

I studied this behaviour of the server with @avatar789, I will open another issue about this with the istructions to reproduce the bug/crash.

In a clean AC the server is vulnerable to this only with specific worldserver confs that I have still find specificly.

[FrancescoBorzi]

yes, let's discuss that in a new issue please