Azerothcore-wotlk: boss_hodir.cpp Script is bugged, SPELL_ICE_SHARDS_SMALL: is casting too much [$50 awarded]

[disclosurez]

boss_hodir.cpp Script is bugged, SPELL_ICE_SHARDS_SMALL: is casting too much

SMALL DESCRIPTION:

boss_hodir.cpp Script is bugged, SPELL_ICE_SHARDS_SMALL: is casting too much

EXPECTED BLIZZLIKE BEHAVIOUR:

SPELL_ICE_SHARDS_SMALL = 62457,
Should not be casting as much as it currently is, this is unplayable for raids as they get raped by continual falling ice.

CURRENT BEHAVIOUR:

SPELL_ICE_SHARDS_SMALL = 62457,

is casting too much, this should be casting a lot less than it is.
I would suggest adding a delay to this cast / script:

switch( spell->Id )
{
case SPELL_ICE_SHARDS_SMALL:
case SPELL_ICE_SHARDS_BIG:
DoAction(1);
break;
}

STEPS TO REPRODUCE THE PROBLEM:

1. Run Hodir In Ulduar
2. Profit

EXTRA NOTES:

BRANCH(ES):

master

AC HASH/COMMIT:

latest

OPERATING SYSTEM:

ubuntu 16.04

MODULES:

none

OTHER CUSTOMIZATIONS:

---

The $50 bounty on this issue has been claimed at Bountysource.

[FrancescoBorzi]

Please do NOT just put "latest" as with time it will no make sense and we won't have trace about when the bug was actually found. Please put your actual commit hash value.

[Viste]

is casting too much, this should be casting a lot less than it is. I would suggest adding a delay to this cast / script
Some proofs ? Or its just in your view?

[Selyria]

So it's hard to tell if it's going too fast with the ice blocks falling from the ceiling.

Because in the 10 man raid it always hits another player.

I'd say it's faster on AC than offi

AzerothCore Video https://youtu.be/5EgVepiPtnA

Offi Video https://www.youtube.com/watch?v=Hcl4tz-XQFo
Offi Video https://www.youtube.com/watch?v=d8Wqg5eP6V8 From the point of view of a distance fighter.

AzerothCore rev. f47c2d2+ 2019-06-03 05:30:11 +0000 (master branch) (Win64, Release)

[disclosurez]

So it's hard to tell if it's going too fast with the ice blocks falling from the ceiling.

Because in the 10 man raid it always hits another player.

I'd say it's faster on AC than offi

AzerothCore Video https://youtu.be/5EgVepiPtnA

Offi Video https://www.youtube.com/watch?v=Hcl4tz-XQFo
Offi Video https://www.youtube.com/watch?v=d8Wqg5eP6V8 From the point of view of a distance fighter.

AzerothCore rev. f47c2d2+ 2019-06-03 05:30:11 +0000 (master branch) (Win64, Release)

vid is 25man, this only affects 10 man

https://www.youtube.com/watch?v=9FMSlpyA8a8

[disclosurez]

sorry guys forgot to mention, this bug only affects 10 man, 25 man is fine

[Selyria]

sorry guys forgot to mention, this bug only affects 10 man, 25 man is fine

okay, i was in the 25-man raid now, too.

The icicles are falling as fast as in 10 man

[disclosurez]

The icicles are falling as fast as in 10 man

yes needs to fall slower in 10 man that is the problem

[Selyria]

The icicles are falling as fast as in 10 man

yes needs to fall slower in 10 man that is the problem

Okay, so it seems like there's gonna be a countdown in between to stop the ice.

In the 10 Man Raid Here good to see https://www.youtube.com/watch?v=VZoAha-2Elc

[Viste]

@Selyria thx for proofs

[Shard-MW]

It should have 4sec delay, according the videos you sent

[solidmaxtor]

In my server players no report any problems with this shards, raids inside everyday in Ulduar.

[Darkon47]

Since the fix was merged in, could we mark this as fixed?

[disclosurez]

Since the fix was merged in, could we mark this as fixed?

yes fixed

[poszer]

Where is fix merged? I can't see it on master. There is just your PR opened @Darkon47 https://github.com/azerothcore/azerothcore-wotlk/pull/2050
Also check this review: https://github.com/azerothcore/azerothcore-wotlk/pull/2050#pullrequestreview-258213775