Azerothcore-wotlk: Deep Wounds does not proc when you crit with ranged weapons

[fragcamp]

Description:
Deep wounds does not proc if you crit with a ranged weapon (thrown, bow, gun)
Current behaviour: Tell us what happens
If your ranged attack crits and you have the deep wounds talent, the deep wounds will not proc on your target.
Expected behaviour: Tell us what should happen instead
Deep wounds should proc with ranged weapons.
Steps to reproduce the problem:

1. Make a warrior
2. Skill Deep Wounds talent
3. Equip a ranged weapon
4. Attack an enemy player with the ranged weapon and wait for a crit
5. When you crit you'll see that deep wounds did not proc on your target.

Branch(es): 0.x / 1.x / master (Specify the branch(es) affected by this issue)
master



AC hash/commit:
https://github.com/azerothcore/azerothcore-wotlk/commit/dd291e0de69a40130473fb54f6088096059d5e32
Operating system:
Win64
Modules: Are you using modules? if yes, list them
None
Other Customizations: Are you using any core/db patches or other customizations? If yes please specify them here.
None

[BarbzYHOOL]

Seems invalid, read this https://github.com/TrinityCore/TrinityCore/issues/20148

Note: I'd prefer if it worked, seems more logic though :p

[lineagedr]

@BarbzYHOOL Seems valid, http://www.wowhead.com/forums&topic=83191/should-all-prot-warriors-be-specced-in-deep-wounds#p902697

By Beefin on 2009/03/23 at 5:52 PM (Patch 3.0.9)

It's worth noting that Deep Wounds will proc off of any crit, your ranged weapon crits will actually proc the bleed. I've seen it account for up to 10% of my overall damage. The other options you have are going for improved shouts in the fury tree. I personally like to contribute to the dps at least a little, doing 1.5k-2k dps as a tank isn't bad. Yet, I might just be old school and still bitter about the days prot warrior dps was just non existant.

[BarbzYHOOL]

I read it too, it's just the opinion of one player though. I have seen many so called pros report wrong stuff on live servers too, so not trusting 1 guy.

Also if you read the TC page, they say ingame Deep Wounds requires melee weapon (client side tooltip) which kind of means it's not for ranged attacks.

Anyway, I don't know what would be best. Adding more dps to Warrior ranged doesn't seem like a bad idea to me :P

[dunjeon]

DBC Spell ID 12834:

Deep Wounds
Requires Melee Weapon
Your critical strikes cause the opponent to bleed, dealing 16% of your melee weapon's average damage over 6 sec.

There isn't anything to suggest that it should work with a ranged weapon.

[BarbzYHOOL]

Yes, I think this issue is... invalid

[BarbzYHOOL]

well so, not suitable for blizzlike, but okay for a custom server, make a module :P