Azerothcore-wotlk: Core/Script: Strand of The Ancients - Ship Bug [$15]

[Narcof]

Description: In the second round of Strand of Ancients one of the two ships does not start.
Current behaviour: In the second round the ship that should arrive to the green gate doesn't start to sail.

Expected behaviour: At the beginning of each round, every ship have to sail

Steps to reproduce the problem:

1. Play Strand of The Ancients
2. Wait for the second round
3. Stay in the left ship ( that should arrive to green gate )
4. It doesn't start to sail

Branch(es): Master

AC hash/commit: d0af1c812bf4ea15204cad37b39ff27ff6bae339
Tested on 626630f0f68998d784c61fbb3779f292f97dc5a8 too

Operating system: Linux

---

Did you fix this issue? Go claim the $15 bounty on Bountysource.

[Yehonal]

Can anyone confirm it please?

[FrancescoBorzi]

I don't know the exact steps to reproduce this issue, however it happened to me more than once when I was playing on trinitycore/azerothcore-based servers. So further investigations are indeed needed.

So I can't confirm the reproducing steps but I can indeed confirm that there is an issue somewhere.

[talamortis]

Since there is two rounds in this battle ground which 1 causing the issue, is it just round 2?

[sucofog]

The problem here, is that our Vehicle system is way outdated, the players are not being correctly registered to the transports, transporte system needs a rewritte

[FrancescoBorzi]

@Narcof are you sure that the steps that you mentioned always reproduce the issue? We need to know the exact sequence that systematically leads to this bug in order to locate it in the code.

[Narcof]

@ShinDarth I've tried this bug 5 times, always in the 2 round. The steps always reproduced that bug

[Irome]

I confirm, I never saw that ship arrive at the second round.

[talamortis]

Ok can anyone tell if its faction specific ?

[sucofog]

It's not faction related @talamortis

[Yehonal]

https://github.com/raczman/TrinityCore/commit/2887864dc96178c8583aaef46acdc2e61e4fbc65

[Yehonal]

imported this fix: https://github.com/azerothcore/azerothcore-wotlk/commit/300847920a2d1c0549659cdb4d15fb382142c931

but unfortunately it doesn't solve this issue, i'll investigate better

[Yehonal]

Moreover it happened to me at first round at battleground start

So i think it's randomic (?)

[pklloveyou]

Sunwell 测试一个小时 没有这个问题 两条船都是同时到达
There was no problem with testing for one hour. Both boats arrived at the same time
Windows 7/64

[FrancescoBorzi]

@pklloveyou what is the version of your server when you did the test?

[pklloveyou]

@ShinDarth Sunwellcore So you can see in sunwell
I am still testing I hope not to go wrong

[FrancescoBorzi]

@pklloveyou can you test it on AzerothCore?

[pklloveyou]

@ShinDarth I'll give it a try I compare to find the possible problems

[FrancescoBorzi]

@pklloveyou thanks a lot

[pklloveyou]

@ShinDarth Very strange two code is not bad word, Exactly the same
This passage is a translator translator I poor in English do not know if you can understand

[FrancescoBorzi]

@pklloveyou thanks for your help, so does it work on AzerothCore for you or not?

[pklloveyou]

@ShinDarth Yes, I translated successfully! The same code word is not bad.

[Inifield]

您是否使用了内核而不进行任何修改？ / Do you use the core without any modifications ?

[pklloveyou]

@Inifield AZ BattlegroundSA.cpp BattlegroundSA.h and Sunwell BattlegroundSA.cpp BattlegroundSA.h same!same!same! Three important things to say HOHO!

[sucofog]

I don't understand chinese xD

[talamortis]

is this intermittent as I've test like 10 times and seems to be working fine.

[Gargarensis]

Tested also by me on 4158d2a0d8a38286eb3c4ff38e147a99252f6f07 and it seems to work at the moment.. there are other conditions to met in order to reproduce the bug?
Tested both by winning the round 1 and by waiting 10 minutes.

[Narcof]

Look this screenshot, made by Narcof in 21/01/2018 on 84949746e1d0dcbfaca2108024b17a044a9ef8b9 @Gargarensis
see this

i was in the second round

[Viste]

@Narcof when you test something, do it from player account! GM account can make a random bugs on bg or instance and with some quest to

[Narcof]

@Viste
This ( 84949746e1d0dcbfaca2108024b17a044a9ef8b9 ) is a test server, we can use GM spells
I can only test this bug on 84949746e1d0dcbfaca2108024b17a044a9ef8b9 because in our main server SOTA is closed

[talamortis]

Issue don't seem to happen on windows going to compile on Linux vps see if i still run into the same problem

[Gargarensis]

The important thing is that you are gm and dev off, then it does not (often) really matter if you are using gm commands.
Let us know @talamortis, I only tested it on windows too.

[Maurowin]

hello, look here, in TC some player said they have a little bugs and others said no. i don't know dev and read correctly a code.
https://github.com/TrinityCore/TrinityCore/blob/master/src/server/game/Battlegrounds/Zones/BattlegroundSA.h
and
https://github.com/TrinityCore/TrinityCore/blob/master/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp

[ZeegCL]

I haven't get this issue reported in our live server (100 players average). I think that the steps to reproduce the error are too generic, maybe specify number of members per team? types of accounts used (GM/player)? etc.

For the moment, I can't confirm this issue.

[FrancescoBorzi]

Has anyone been able to reproduce this issue recently? I think this issue might still be there but it's very hard to reproduce