Azerothcore-wotlk: Seduction on Spell Reflection

[Narcof]

Description: Succubus cast "Seduction" on warrior with Spell Reflection, the succubus reflect the Seduction spell on it. It shouldn't happen because Succubus isn't a Humanoid

Current behaviour: When a succubus cast "seduction" on a warrior with Spell reflection, the succubus reflect this spell on it

Expected behaviour: When a succubus cast "seduction" on a warrior with Spell reflection, the seduction spell shouldn't return on Succubus

Steps to reproduce the problem:

1. let cast your succubus a seduction on a warrior with spell reflection
2. See the debuff on succubus

Branch(es): Master

AC hash/commit: d0af1c812bf4ea15204cad37b39ff27ff6bae339

Operating system: Linux

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[lineagedr]

Can you provide proof that it shouldn't return on succubus?

[Yehonal]

@lineagedr one proof should be that the spell can only be casted on humanoid, instead the succubus is a demon. But i'm not sure

[Narcof]

@lineagedr it's simple,

1. when a succubus cast "seduction" it stay in cast ( like a channeling spell ). if succubus take seduction it can't continue to cast this spell

2. Seduction can only be casted on humanoid, succubus is a demon

[lineagedr]

@Narcof @Yehonal
Fair point, I have a fix but it's very hacky.

[Yehonal]

i'm curious :)

[lineagedr]

@Yehonal https://pastebin.com/e66rdHCB add below

https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/game/Spells/Spell.cpp#L2397

[pak3935]

Hibernate is reflected in the player with Spell Reflection
http://bfa.wowhead.com/spell=2637/hibernate

[BarbzYHOOL]

Seduction must only target humanoids, it would solve all issues

[pak3935]

any news

[BarbzYHOOL]

Waiting for a dev to take over :P

[ghost]

Can't reproduce this issue, spell reflected and sucubus wasn't charmed.

[talamortis]

cant reproduce either.

[BarbzYHOOL]

If someone reopens this, plz add the commands to easily test like ".cast xxxxx" etc