Axe-core: Incorrect typings for `axe.RunOnly`

Created on 26 Jun 2018  路  3Comments  路  Source: dequelabs/axe-core

The TS definitions for axe.RunOnly are incorrect. As suggested by axe-core.org, the runOnly option should have a property values which is an Array of rule IDs. However, in the TS definition, RunOnly is either an Array of TagValues or a RunOnlyObject (which has properties include and exclude, making it look like it belongs to ElementContext, not RunOnly).

It looks like these definitions are built by hand, so if you're all on-board, I'd be happy to fix it.

picture stephenmathieson

Most helpful comment

Shouldn't the issue stay open until the PR is merged?

picture marcysutton on 26 Jun 2018
👍3

All 3 comments

yep, it should always be an Array of Strings which are either tags or rule IDs

dylanb picture dylanb on 26 Jun 2018

PR - https://github.com/dequelabs/axe-core/pull/973

jeeyyy picture jeeyyy on 26 Jun 2018

Shouldn't the issue stay open until the PR is merged?

marcysutton picture marcysutton on 26 Jun 2018
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

JoshuaKGoldberg picture JoshuaKGoldberg  路  5Comments
AdrienLemaire picture AdrienLemaire  路  4Comments
keeganbrown picture keeganbrown  路  4Comments
NithinGCC picture NithinGCC  路  7Comments
robpaveza picture robpaveza  路  5Comments