Awesome-go: Date/Time header link in TOC broken on awesome-go.com

Created on 15 Dec 2016  Â·  8Comments  Â·  Source: avelino/awesome-go

  • Date/Time header link in TOC doesn't work
  • ORM list appears as a paragraph, not a list

Most helpful comment

I got an idea for a temporary workaround fix.

We can just rename those heading not to include the problematic & symbol. I.e., use "Date and Time" rather than "Date & Time".

It wouldn't completely resolve the issue, but at least fix it for the users. It's easy and quick.

All 8 comments

ORM list appears as a paragraph, not a list

Can't reproduce. It seems fine to me:

image

Goroutines section, on the other hand, does have an issue:

image

Woops, you're right. It was the goroutine section that had the paragraph problem.

Ok, I've fixed that second issue in b9ad39eb9ebe1916b2d9e74bdd038aa00611e74c. Goroutines section now looks okay:

image

Can you not reproduce the link issue?

On Wed, Dec 14, 2016 at 5:15 PM Dmitri Shuralyov notifications@github.com
wrote:

Ok, I've fixed that second issue in b9ad39e
https://github.com/avelino/awesome-go/commit/b9ad39eb9ebe1916b2d9e74bdd038aa00611e74c.
Goroutines section now looks okay:

[image: image]
https://cloud.githubusercontent.com/assets/1924134/21208113/faad145a-c239-11e6-9cb1-7ee18ee3a94a.png

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/avelino/awesome-go/issues/1224#issuecomment-267207905,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD5Vn6hSPzB4thDRt7LW5nhh17QZFrzks5rIJStgaJpZM4LNj6Q
.

I can. That's why this issue is still open.

It's not just "Date & Time" link, it's also "Generation & Generics", "Authentication & OAuth", and any other header with an ampersand.

It happens because of the difference in Markdown rendering between github.com and what is used on awesome-go.com. Compare:

https://github.com/avelino/awesome-go#date--time

http://awesome-go.com/#date-time

GitHub expects two dashes, but awesome-go.com one.

I got an idea for a temporary workaround fix.

We can just rename those heading not to include the problematic & symbol. I.e., use "Date and Time" rather than "Date & Time".

It wouldn't completely resolve the issue, but at least fix it for the users. It's easy and quick.

Fixed with #1505

Was this page helpful?
0 / 5 - 0 ratings

Related issues

xhit picture xhit  Â·  6Comments

qrpike picture qrpike  Â·  7Comments

mrKappen picture mrKappen  Â·  6Comments

ldemailly picture ldemailly  Â·  6Comments

PotHix picture PotHix  Â·  8Comments