Awesome-go: Add a new rule to the guideline
The project currently has 163 pull requests waiting for approval. Many of them are waiting for the author, instead of waiting for approvers.
I propose to add a new condition to all PRs: If the pull request was reviewed and is waiting for the author interaction for more than 5 days, it will be closed.
A project that is just text and has more than 150 opened PRs is weird for those who don't know it, this change will help with that.
PotHix
All 8 comments
I'd say a time limit is a good idea, but 5 days may be too short a window, most people are pretty busy.
eg. Person finds time on Sunday to make a PR that requires some changes that he doesn't see till Monday but is busy with work, kids, open source projects etc... The PR would get closed before he may even find time to make changes.
I'd say at least 8 days to be fair, maybe longer, thoughts?
deankarn
on 16 Jun 2017
LGTM
PotHix
on 16 Jun 2017
LGTM
felipeweb
on 16 Jun 2017
@PotHix send PR upgrade contribute file and PR template pls
avelino
on 16 Jun 2017
LGTM @PotHix Please send the PR.
appleboy
on 16 Jun 2017
LGTM with more days than 5. 8-10 looks fine, but no more than 14.
matrixik
on 16 Jun 2017
LGTM, thanks @PotHix
dukex
on 16 Jun 2017
LGTM, and I agree with @matrixik
kirillDanshin
on 16 Jun 2017
Related issues
kweber-tcc
路
51Comments
kaxap
路
21Comments
dmitshur
路
6Comments
flimzy
路
17Comments
mrKappen
路
6Comments
Most helpful comment
I'd say a time limit is a good idea, but 5 days may be too short a window, most people are pretty busy.
eg. Person finds time on Sunday to make a PR that requires some changes that he doesn't see till Monday but is busy with work, kids, open source projects etc... The PR would get closed before he may even find time to make changes.
I'd say at least 8 days to be fair, maybe longer, thoughts?