Atrium: Path.toBeASymbolicLink

Created on 2 Jan 2021  路  8Comments  路  Source: robstoll/atrium

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

expect(path).toBeASymbolicLink()

//instead of

expect(path).feature { f(it::isSymbolicLink)}.toBe(true)

Following the things you need to do:

logic

  • [ ] extend PathAssertions with a function toBeASymbolicLink (see isRegularFile as a guideline)
  • [ ] implement toBeSymbolicLink in DefaultPathAssertions.kt`

api-fluent

  • [ ] provide a fun toBeASymbolicLink (see isRegularFile as a guideline)
  • [ ] add @since 0.16.0 (adapt to current milestone) to KDOC
  • [ ] add isSymbolicLink to PathExpectationsSpec in specs-common adopt the spec in api-fluent

api-infix

  • [ ] provide a fun toBe which expect a new pseudo-keyword aSymbolicLink (see toBe(aRegularFile)` as a guideline)
  • [ ] add @since 0.16.0 (adapt to current milestone) to KDOC
  • [ ] add toBe aSymbolicLink to PathExpectationsSpec in specs-common adopt the spec in api-fluent
  • [ ] add an example to PathAssertionSamples (create the file next to BigDecimalAssertionSamples if it does not exist yet).

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
good first issue help wanted

All 8 comments

I vote to name the function toBeASymbolicLink.

Good with me, I was considering it as well (already did it for the infix API)

I'll work on this

@fimbulwint note that I have updated the description. Have fun implementing and let us know in case you need help

@robstoll Thanks!

@robstoll I'm ready to create a PR, but I don't have permissions to push/create the tracking branch

@fimbulwint you should fork this repository, push the branch to your fork, and then open a Pull Request from your fork. See also Creating a Pull Request from a Fork.

@jGleitz thank you, done that now

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robstoll picture robstoll  路  4Comments

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  6Comments

robstoll picture robstoll  路  3Comments