Atrium: filter jasmine out of error-stacks

Created on 31 Jan 2020  路  8Comments  路  Source: robstoll/atrium

Platform (jvm, js, android):
Extension (none, kotlin 1.3, jdk8): none

Error Reporting related feature

Currently we filter only stackframes of mocha, we could enhance it with stackframes of jasmine
Following the things you need to do:

lib

  • [ ] core/robstoll-lib/atrium-core-robstoll-lib-js/src/main/kotlin/ch/tutteli/atrium/core/robstoll/lib/reporting/RemoveRunnerAtriumErrorAdjuster.kt => add jasmine
  • [ ] add corresponding tests to ch.tutteli.atrium.core.robstoll.lib.reporting.AdjustStackTest
  • [ ] adjust README, search for notToThrow, it mentions somewhere mocha, add jasmine in addition

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
good first issue help wanted

All 8 comments

Send me more information and I will work on this

@sabankay1120 what information do you need in addition?

I'll work on this

@z13z great that you are that motivated :slightly_smiling_face: Please don't work on more issues in parallel, let's try to get the once you are assigned to into master first.

I can't find mocha in README.md (inside notToThrow). Was it deleted?

you find mocha around line 496
Stack frames of Atrium and of test runners (Spek, Kotlintest and JUnit for JVM, mocha for JS) are excluded per default

Errors in AdjustStackTest doesn't contain string "jasmine", even after changing regex in RemoveRunnerAtriumErrorAdjuster.kt to (\s|\S)+. how can I produce exception with correct stack trace in given test class to add new test cases

Oh well, seems like I have not thought that through when I wrote the description. You cannot in AdjustStackTraceSpec as we are using mocha as runner and not jasmine. However, you can add your test case to /samples/js/jasmine/src/test/kotlin/org/atriumlib/samples/jasmine/SampleJsTest.kt.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robstoll picture robstoll  路  6Comments

robstoll picture robstoll  路  4Comments

robstoll picture robstoll  路  5Comments

robstoll picture robstoll  路  5Comments

robstoll picture robstoll  路  6Comments