Atrium: Path.endsNotWith

Created on 6 Oct 2019  路  1Comment  路  Source: robstoll/atrium

Platform (jvm, jdk8, js, android): jdk8

Code related feature

expect(path).endsNotWith(otherPath)

//instead of

expect(path).feature { f1(it::endsNotWith, otherpath) }.toBe(true) 

However, in reporting we only want to see (in contrast to the feature version):

expect: Path...
* ends not with: Path

Following the things you need to do:

domain

  • extend PathAssertions with a function endsNotWith (see other functions as a guideline)
  • modify PathAssertionsBuilder, delegate to pathAssertions (see other functions as a guideline)
  • delegate implementation to robstoll-lib in PathAssertionsImpl (see other functions as a guideline)

lib

  • implement _endsNotWith in pathAssertions by using the ExpectImpl.builder.descriptive... (see /domain/robstoll-lib/atrium-domain-robstoll-lib-common/src/main/kotlin/ch/tutteli/atrium/domain/robstoll/lib/creating/charSequenceAssertions.kt -> _endsNotWith)

    • add ENDS_NOT_WITH("ends not with") to DescriptionPathAssertion for en_GB

    • add ENDS_NOT_WITH("endet nicht mit") to DescriptionPathAssertion for de_CH

api (fluent-en_GB/extension/jdk8)

  • provide a fun endsNotWith
  • add @since 0.9.0 to KDOC
  • add endsWith to PathAssertionsSpec in specs-common and extend it in atrium-api-fluent-en_GB-common/src/test

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
good first issue hacktoberfest help wanted

Most helpful comment

I'll work on this

>All comments

I'll work on this

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  4Comments

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  6Comments

robstoll picture robstoll  路  4Comments