Atom-beautify: When beautify on save, don't unfold all the current code folds
I have, beautify-on-save checked and when I save one of my js files, it unfolds all the code blocks I have folded up so then I have to go back and refold them all. This is by no means a high priority issue, but more something that would be a really nice enhancement to have.
I also understand this might be something completely out of atom-beautifiers control too.
toddbluhm
All 13 comments
Will have to do a little research to investigate if that is doable from my end with Atom Beautify. Beautification writes out beautified code to the editor, consequently removing all the un/fold marks and then re-creating them for the new code.
Thanks for bringing this issue to my attention. Hopefully something can be figured out.
Glavin001
on 6 Oct 2014
May be able to accomplish this in the same way it works currently for cursors (save previous states, and restore after beautify): https://github.com/Glavin001/atom-beautify/blob/master/lib/beautify.coffee#L30-L48
Since the code has the potential to change dramatically, this may not work.
Glavin001
on 8 Oct 2014
Awesome! Thank you so much for looking into this. Sounds like you have a place to start. Thanks for keeping me updated. I look forward to trying it out if you get it working :)
toddbluhm
on 9 Oct 2014
Upon reflection I think this is something that should be handled inside of Atom. Unfortunately, I am not sure how they will accomplish this, however I suggest that their setText function on the TextEditor somehow diffs the input from the current text state and knows how to properly setup the folds in relatively the same state as before.
I hope that this is something they will support in the future.
Glavin001
on 10 Jun 2015
There is an implementation I found that looks promising.
Sublime-HTMLPrettify: https://github.com/victorporof/Sublime-HTMLPrettify
Glavin001
on 19 Aug 2015
something like that occurs with linter-jscs :(
RiCoTeRoX
on 18 Feb 2016
Is there a little update on this? Constantly folding/unfolding does not make a lot of fun.
Szandor72
on 11 Jan 2017
I would find this feature greatly useful as well.
teeramusic
on 4 Feb 2017
Dear God, yes please. Have this feature would be a big time saver.
dlewand691
on 7 Mar 2017
It looks like Atom now supports setTextViaDiff: https://atom.io/docs/api/v1.17.2/TextBuffer#instance-setTextViaDiff
Replace the current buffer contents by applying a diff based on the given text.
This would be our best shot to get this to work -- let Atom deal with the changing of the text and state of the folds.
This would require changing https://github.com/Glavin001/atom-beautify/blob/8ead568182b16bf2aa0086568692ed0d88c823bf/src/beautify.coffee#L120 and testing it out.
Pull Requests very welcome!!
Glavin001
on 28 May 2017
Original (un-beautified)
<!doctype html>
<html>
<head>
<title>Test Page</title>
</head>
<body>
<h1>Hello</h1><p>
World!
</p>
</body>
</html>
Before (with folds)
After
Current Version (setText)
Next Version (setTextViaDiff)
It worked! All folds are preserved.
And if I manually unfold:
Looks good!
Glavin001
on 28 May 2017
Published to v0.29.26
Glavin001
on 28 May 2017
@Glavin001 Thanks so much! This is awesome! And thanks for not letting this issue die off.
toddbluhm
on 30 May 2017
Related issues
edwardm
路
5Comments
opikhidayat
路
4Comments
suienzan
路
3Comments
misterernest
路
3Comments
catscarlet
路
3Comments
Most helpful comment
@Glavin001 Thanks so much! This is awesome! And thanks for not letting this issue die off.