Async: 2.0.0 ready to go?

[aearly]

I think its time. Everything in the milestone is complete, and the docs site is up and running. (except for the during inconsistency issue, which I think is just a docs fix)

I think 2.0.0 is ready for to be released into the wild!

cc @megawac

[megawac]

I agree after we resolve #1217

[gemox94]

Hi. I'm starting with node so I was following a tuto where uses async.parallel. So when I wanted to run the app it throws me an error in async module and the error was that async couldn´t find applyEach module:
"Error: Cannot find module './applyEach'"
And I saw that the version of async was 2.0.0, so I decided to install an older version, specifically the version is 1.5.2 and the error disappeared.

[megawac]

Ohhh, thats a good point @aearly we should test all the modules after we run the compile step. Can we configure the index.js file mocha uses to test?

[megawac]

@gemox94 I actually can't reproduce this. Can you provide code to reproduce this issue?

[aearly]

Well, last issue closed! I say we wait until Monday to release. It would be bad to inadvertently cause some issues when most people are off for the weekend.

[megawac]

Sure, lets review the changelog and make sure its prepared

[tekwiz]

I just added an issue that I think should be resolved before v2 is released: #1225. I don't give a significant amount of weight to code-coverage results without a great deal of investigation into their configuration, but I feel this should be resolved before a major release.

That said, as a non-owner, I can say I am still 100% comfortable using the v2 release without code-coverage test results, so it may be more efficient to simply remove the Coveralls badge and circle back to resolve it afterwards.

[aearly]

Coverage not working isn't a showstopper. We can fix this later. I don't know it it has worked at all since modularization.

[megawac]

I think the issue is ES6 imports

[megawac]

@aearly lets release tomorrow@noon (est), sound good?

[aearly]

How about 1pm EST? (9am PST is a bit early)

[131]

It's time, it's time ! (furiously waiting for the -rc to disappear)

[megawac]

Hehe, a couple issues got opened last night @131, we have to triage them before release. Waiting on @aearly feedback on a couple of the PRs before we go ahead

[megawac]

https://github.com/caolan/async/milestone/1 for reference

[megawac]

Some final things I noticed giving the jsdoc a final look over:

1) document inserting multiple items into queue/cargo. Array form not documented.
2) lib/iterator isn't used at all internally. Does this even deserve to live in async any longer? I'd say kill it in favour of ES-2015 iterators which natively support arrays.
3) race to support iterables? (maybe v2.1?)
4) waterfall to support iterables? (maybe v2.1?)

[aearly]

3) and 4) can wait for 2.1 . I also think Array literals are way more useful for those functions. Supporting generic iterables could lead to some interesting control flow options I haven't foreseen though. race could also support objects.

[aearly]

I :clap: Think :clap: We're :clap: Ready :clap: To :clap: Go :open_mouth:

[megawac]

[aearly]

2.0.0 is live! https://www.npmjs.com/package/async

[aearly]

Now we wait for the inevitable bug reports... :dizzy_face: :sweat_smile:

[megawac]

Do you have some unstaged changes to docs @aearly? Generating the docs on my machine don't turn out the same as gh-pages?

[aearly]

Nope, everything is up to date on my end. What's different?