Argo-cd: switch monkeypatching implementation for license reasons

Created on 23 Sep 2020  路  1Comment  路  Source: argoproj/argo-cd

Monkeypatching is being used for one of the tests - https://github.com/argoproj/argo-cd/search?q=bou.ke%2Fmonkey

The implementation is coming from archived git repo and the license says not to use it - https://github.com/bouk/monkey/blob/master/LICENSE.md

This has turned up in a license scan for our project that is using an argocd dependency as it's part of the argocd mod file, even though it's a test dependency.

There is an MIT-licensed alternative available. Could the implementation be switched to that?

tech-dept

Most helpful comment

/assign @jopit

@alexmt I can look at replacing bou.ke/monkey with github.com/undefinedlabs/go-mpatch (https://github.com/undefinedlabs/go-mpatch) if that package is acceptable

>All comments

/assign @jopit

@alexmt I can look at replacing bou.ke/monkey with github.com/undefinedlabs/go-mpatch (https://github.com/undefinedlabs/go-mpatch) if that package is acceptable

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nouseforaname picture nouseforaname  路  3Comments

jessesuen picture jessesuen  路  3Comments

turbotankist picture turbotankist  路  3Comments

ksaito1125 picture ksaito1125  路  3Comments

travis-sobeck picture travis-sobeck  路  3Comments