Argo-cd: App creation UI should allow specifying values files outside of helm app directory

[alexmt]

Value files are not necessary inside helm app directory. It should be possible to specify files outside of directory as well.

API /api/v1/repositories/{repo}/apps/{path} should return all value files of repo instead of only files inside helm directory

[jessesuen]

Consider the case of github.com/helm/charts. I think showing all value files of that repo is excessive. I think showing only what's in the directory, but also providing a text field allowing the user to point it out of the directory, or a URL would be sufficient.

[alexmt]

Good suggestion @jessesuen .

It seems like people are expecting that values path should be relative to git repo root path, not to the chart path. In addition to text box should we make path relative to git repo root path? (in controller and api )

[marcellodesales]

@alexmt @jessesuen I had the same issue this week... Could we have filters to define the pattern for files? Helm files can be in any name, not necessarily prefixed with values-...

[jessesuen]

It seems like people are expecting that values path should be relative to git repo root path, not to the chart path. In addition to text box should we make path relative to git repo root path?

Hmm. I actually think it's less intuitive for it to be relative to the git repo (vs. relative to the chart dir). I checked our internal helm chart users, and they all seem to have their values files sitting in the chart directory. Plus this would be a breaking change to switch the behavior.

[alexmt]

Fixed by https://github.com/argoproj/argo-cd-ui/pull/56 . Dropdown had been replaced with textbox + autocompletion. Now user can specify and values file location.